Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable graceful suggestion matching #52789

Closed
jrieken opened this issue Jun 25, 2018 · 1 comment
Closed

Add option to disable graceful suggestion matching #52789

jrieken opened this issue Jun 25, 2018 · 1 comment
Assignees
@jrieken
Labels
feature-request Request for new features or functionality suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone
July 2018

Comments

@jrieken
Copy link
Member

jrieken commented Jun 25, 2018

With the November 17 release we have added support for graceful suggestion matching. While scoring and ranking suggestions against the current prefix some permutations are tried. The rule is that neighbouring characters are swapped, e.g. cnos, as cons and cnso (the first is stable). All permutations are ranked and the highest score wins.

This fixed https://github.com//Microsoft/vscode/issues/15419 and the underlying theory is that users tend misspell by swapping neighbouring characters.

As #52500 shows, not everyone likes this and we should add a setting to disable graceful matching.
@jrieken jrieken self-assigned this Jun 25, 2018
@jrieken jrieken added feature-request Request for new features or functionality suggest IntelliSense, Auto Complete labels Jun 25, 2018
@jrieken jrieken mentioned this issue Jun 25, 2018
Closed
@stef-levesque stef-levesque mentioned this issue Jun 26, 2018
Closed
@jrieken jrieken added this to the July 2018 milestone Jul 2, 2018
jrieken added a commit that referenced this issue Jul 2, 2018
@jrieken
add editor.suggest-options bag, toward #42750 and configure graceful …
32d9f16 
…filtering for #52789
jrieken added a commit that referenced this issue Jul 2, 2018
@jrieken
wire up editor.suggest.filterGraceful #52789
91e82ed
@jrieken
Copy link
Member Author

jrieken commented Jul 2, 2018

I have pushed a new setting called editor.suggest.filterGraceful (defaults to true) which can be used to turn off graceful matching.

@jrieken jrieken added the verification-needed Verification of issue is requested label Jul 2, 2018
@jrieken jrieken closed this as completed Jul 2, 2018
@JacksonKearl JacksonKearl added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Jul 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
2 participants
@jrieken @JacksonKearl