Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No syntax highlighting for in-product release notes code blocks. #53413

Closed
gregvanl opened this issue Jul 2, 2018 · 7 comments
Closed

No syntax highlighting for in-product release notes code blocks. #53413

gregvanl opened this issue Jul 2, 2018 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@gregvanl
Copy link

gregvanl commented Jul 2, 2018

  • VSCode Version: 1.25 Insiders
  • OS Version: Windows 10

Steps to Reproduce:

  1. Help > Release Notes
  2. Look for json or TypeScript code blocks

image

Code blocks are simply white on black (default dark theme) with no syntax highlighting.

Seems to only happen on the first time. If you close the release notes and try again, the code blocks are correctly highlighted.

@gregvanl
Copy link
Author

gregvanl commented Jul 2, 2018

DevTools console output:
INFO no standard startup: not just one text editor
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope source.applescript
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope text.html.textile
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope source.c++
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope source.js.jquery
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope source.smarty
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope source.dosbatch
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope source.scala
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope source.dart
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope text.html.javadoc
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope source.postscript
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope source.sass
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope source.less
/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:1375 INFO No grammar found for scope source.stylus
2/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:3543 [Embedded Page] Blocked script execution in 'data:text/html;charset=utf-8,%3C%21DOCTYPE%20html%3E%0D%0A%3Chtml%20lang%3D…100%25%3B%20height%3A%20100%25%22%3E%0D%0A%3C%2Fbody%3E%0D%0A%3C%2Fhtml%3E' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.

@gregvanl
Copy link
Author

gregvanl commented Jul 2, 2018

No such console output on second try when there is syntax highlighting.

@gregvanl
Copy link
Author

gregvanl commented Jul 2, 2018

I wonder if this could be due to change to delay load TextMate grammars 54ff9a1#diff-7d43e3fab25f026e232da23df0f2139c @aeschli

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jul 2, 2018
@mjbvz mjbvz added this to the June 2018 milestone Jul 2, 2018
mjbvz added a commit that referenced this issue Jul 2, 2018
@mjbvz mjbvz closed this as completed in 090d912 Jul 2, 2018
@joaomoreno joaomoreno added the candidate Issue identified as probable candidate for fixing in the next release label Jul 3, 2018
@bpasero bpasero added the verified Verification succeeded label Jul 3, 2018
@gregvanl
Copy link
Author

gregvanl commented Jul 5, 2018

@mjbvz I still see this issue for in-product release notes. Just saw it for 1.25 Stable update. Shall I reopen this issue or create a new one?

@mjbvz mjbvz reopened this Jul 5, 2018
@mjbvz mjbvz modified the milestones: June 2018, July 2018 Jul 6, 2018
@mjbvz mjbvz removed candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded labels Jul 6, 2018
@aeschli
Copy link
Contributor

aeschli commented Jul 9, 2018

The output No grammar found for scope source.applescript is caused by changes by my change and is just for info. We should track this in a separate issue. I created #53860

@mjbvz
Copy link
Contributor

mjbvz commented Jul 27, 2018

@aeschli Do you think we will have a chance to look into this early next week?

@gregvanl
Copy link
Author

This seems to be fixed in 1.26.0

@roblourens roblourens added the verified Verification succeeded label Aug 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants