Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 7 (classic theme): Title flashes with custom menubar enabled #56630

Closed
Thunraz opened this issue Aug 17, 2018 · 21 comments
Closed

Windows 7 (classic theme): Title flashes with custom menubar enabled #56630

Thunraz opened this issue Aug 17, 2018 · 21 comments
Assignees
Labels
electron Issues and items related to Electron menus Menu items and widget issues titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream windows 7 VS Code on Windows 7 issues

Comments

@Thunraz
Copy link

Thunraz commented Aug 17, 2018

When window.titleBarStyle is set to custom there is a brief flash of the native title bar when switching between files. This behavior also happens for me in the current Insiders build, but didn't occur in v1.25.1.

titlebar-flash

  • VSCode Version: Code 1.26.0 (4e93618, 2018-08-13T16:29:31.933Z)
  • OS Version: Windows 7 Professional SP1 (Windows_NT x64 6.1.7601)

Steps to Reproduce:

  1. Switch between open files

Does this issue occur when all extensions are disabled?: Yes

@bpasero
Copy link
Member

bpasero commented Aug 17, 2018

@Thunraz are you using some custom window manager or theming program?

@bpasero bpasero added the info-needed Issue requires more information from poster label Aug 17, 2018
@Thunraz
Copy link
Author

Thunraz commented Aug 17, 2018

@bpasero no, just regular Windows.

Edit: to compare with the expected behavior, I've installed 1.25.1 again:
titlebar-no-flash

@bpasero
Copy link
Member

bpasero commented Aug 17, 2018

@Thunraz interesting, and in 1.25 you are also using the custom title bar style right?

In that case I suspect an issue with the Electron update.

Can you just try with a very new version of VSCode (make sure to set title bar to custom again): https://az764295.vo.msecnd.net/exploration/57d01751b88c89046b33be3f1d55f860041fd27b/VSCode-win32-x64-1.27.0-exploration.zip

@Thunraz
Copy link
Author

Thunraz commented Aug 17, 2018

@bpasero Yes, in 1.25 I was also using custom title bar style (I've updated my comment above with a GIF showing the expected behavior).

Unfortunately, the Exploration version of VSCode shows the same behavior:
titlebar-exploration-flash

I've just done another test since I'm using the "classic" Windows theme (i.e. Windows 9x/2000 window styles). When using the "modern" theme, there's no native title bar flash:

titlebar-modern-theme-no-flash

@bpasero
Copy link
Member

bpasero commented Aug 17, 2018

@Thunraz yeah so it is indeed related to changing a theme in Windows 7 it seems.

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron-2.0.x-update electron Issues and items related to Electron labels Aug 17, 2018
@bpasero bpasero changed the title Switching between files causes flash of native title bar when using custom titleBarStyle Windows 7 (classic theme): Title flashes with custom menubar enabled Aug 17, 2018
@vscodebot vscodebot bot removed the new release label Aug 21, 2018
@vscodebot vscodebot bot closed this as completed Aug 28, 2018
@vscodebot
Copy link

vscodebot bot commented Aug 28, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@Thunraz
Copy link
Author

Thunraz commented Aug 28, 2018

Is there any more information I could provide?

@bpasero bpasero reopened this Aug 29, 2018
@bpasero bpasero removed the info-needed Issue requires more information from poster label Aug 29, 2018
@bpasero
Copy link
Member

bpasero commented Aug 29, 2018

At this time no, I fear I have no workaround currently other than not using that windows theme.

@kanlukasz
Copy link

I have the same problem.
Windows 7 Classic Theme (no areo)
Fresh install 1.31.1

@kanlukasz
Copy link

kanlukasz commented Mar 5, 2019

Temporary solution:

Change Title Bar Style to native

obraz

@anikolaev
Copy link

@kanlukasz Thanks for workaround but in this mode 'Alt' keypress doesn't activate the menu bar. Light menu bar doesn't look good with dark themes. Vertical space is wasted.

I wish it could be fixed. That's is one of the reasons I don't use VS Code.

@mtsh1000
Copy link

mtsh1000 commented Sep 16, 2019

There is also another side effect of this glitch, that the window title bar stays on top of developer tools menu bar.
vscode_title

@sbatten sbatten added menus Menu items and widget issues and removed workbench-menu labels Oct 7, 2019
@bpasero
Copy link
Member

bpasero commented Oct 8, 2019

We are building exploration builds that use a much newer version of our UI framework (Electron version 6.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

@bpasero bpasero added the info-needed Issue requires more information from poster label Oct 8, 2019
@Thunraz
Copy link
Author

Thunraz commented Oct 8, 2019

Unfortunately the issue persists with the exploration build.

@bpasero bpasero added confirmed Issue has been confirmed by VS Code Team member titlebar VS Code main title bar issues and removed info-needed Issue requires more information from poster confirmed Issue has been confirmed by VS Code Team member labels Oct 10, 2019
@bpasero bpasero removed their assignment Oct 15, 2019
@bpasero
Copy link
Member

bpasero commented Oct 15, 2019

@sbatten moving forward you need to come up with a standalone reproducible sample and file this to Electron if we want a fix. I think leaving this issue dormant without this action we can equally just close this as wontfix.

@sbatten
Copy link
Member

sbatten commented Oct 15, 2019

I'll try with Electron Fiddle in a Win7 VM. Assigned to October just for getting a repro and upstream bug.

@sbatten sbatten added this to the October 2019 milestone Oct 15, 2019
@mtsh1000
Copy link

This seems to be related to that Win 7 basic theme uses GDI for drawing while aero theme and all later windows versions use DirectX.

@sbatten
Copy link
Member

sbatten commented Oct 23, 2019

After quite a bit of playing around, the culprit is outlined in the upstream bug linked above. The good news is, there is another workaround that one can use if you don't really care about so much state in the window title.

Workaround:
Set the setting window.title to something static like ${appName} or ${appName} - ${folderName}. This will stop the title from being updated on editor changes and prevent the bug from surfacing.

@sbatten sbatten added the upstream-issue-linked This is an upstream issue that has been reported upstream label Oct 23, 2019
@sbatten sbatten modified the milestones: October 2019, Backlog Oct 23, 2019
@sbatten
Copy link
Member

sbatten commented Oct 16, 2020

Redirecting to @deepak1556 to retriage this since upstream has no traction

@sbatten sbatten assigned deepak1556 and unassigned sbatten Oct 16, 2020
@sbatten sbatten removed this from the Backlog milestone Oct 16, 2020
@gabrielsclima
Copy link

gabrielsclima commented Apr 2, 2021

Can still reproduce on my VsCode too, but the workaround fixed the issue.
I have a doubt: Can you tell me which Electron version VsCode is currently using?
Edit: alredy found it

@alexdima alexdima added the windows 7 VS Code on Windows 7 issues label Mar 15, 2022
@deepak1556
Copy link
Contributor

Windows 7 is no longer supported by VSCode, you can read more about it at https://code.visualstudio.com/docs/supporting/faq#_can-i-run-vs-code-on-windows-7

@deepak1556 deepak1556 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron Issues and items related to Electron menus Menu items and widget issues titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream windows 7 VS Code on Windows 7 issues
Projects
None yet
Development

No branches or pull requests

10 participants