Update Fails

[biltongza]

Issue Type: Bug

Trying to update VSCode, the update fails every time even after restarting as suggested.

VS Code version: Code 1.26.1 (493869e, 2018-08-16T18:38:57.434Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz (4 x 2808)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	15.87GB (11.69GB free)
Process Argv	C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader	no
VM	0%

Extensions (10)

Extension	Author (truncated)	Version
npm-intellisense	chr	1.3.0
gitlens	eam	8.5.6
vscode-npm-script	eg2	0.3.5
auto-close-tag	for	0.5.6
vscode-yarn	gam	1.6.0
sublime-babel-vscode	jos	0.2.10
csharp	ms-	1.15.2
PowerShell	ms-	1.8.4
vs-keybindings	ms-	0.2.0
vscode-icons	rob	7.26.0

Log attached as suggested by the error message that pops up after trying to do the update.

vscode-inno-updater-1536658349.log

I've also tried rebooting in between update attempts, doesn't seem to change anything.

Log is complaining that access is denied. I have administrative privileges and I got a UAC prompt before the update started so I don't think it's a permission issue. I have Symantec Endpoint Protection which I can't get rid of/disable as this is a corporate machine.

I don't see anything in its logs about this though.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Failed to install VS Code update (#56809)
• restart to update issue (#25733)
• Restart To Update should use the latest version and not the first downloaded version (#46312)
• VSCode update fails when unable to rename file (#50017)
• Feature request: Update on next restart (#38876)

[JohnnyWestlake]

Even though this has been reported many, many times in recent weeks... happy to leave this here for visibility until it actually gets fixed because not a lot seems to be getting done about it.

[joaomoreno]

I have Symantec Endpoint Protection which I can't get rid of/disable as this is a corporate machine.

Can you temporarily disable it, and if so, does the update go through when it's disabled?

[biltongza]

@joaomoreno Unfortunately not, it seems to be controlled by group policy or something that's stopping me from disabling it. I've tried adding code to as many exclusion lists as I can (since I am able to change those), but it has made no difference unfortunately.

Not sure if it's relevant, but just after the "restart to update" notification appears (note I haven't clicked on anything yet), my system stops responding to all inputs for a solid 10-15 seconds before carrying on. USB mouse + trackpad both have no effect on the cursor, but the machine is still "responding" because I can see loading spinners moving in the background. Keyboard input also has no effect. After the delay, all the mouse movements and keyboard inputs suddenly "catch up" if that makes sense.

[biltongza]

For what it's worth, I just tried reinstalling code (1.26.1) to C:\vscode\ so it isn't living in Program Files, and I still get the same issue. Also, I got that system "hang" just after installing code again like I get when running the update.

[PegasusT4]

Same problem. Just installed VC 1.31.0 on Dell XPS with Win10-64bit and get the same error. I previously had the VC insiders and had the same problem so switched to just VC. Also have had the same problem on a HP Spectre x360 with Win 10-64bit.
operation_log.txt
vscode-inno-updater-1550021067.log

[totkeks]

@joaomoreno played around with this issue a little more.
The System process (PID 4) keeps an open file handle when starting/closing Code.exe.
It does not matter if the background updater is enabled or not.
It doesn't even matter if extensions are enabled or not. Tried this with code.exe --disable-extensions
When trying to close the handle via Sysinternals Process Explorer the error message is the handle is invalid.
This then breaks any kind of updates.

Interesting thing though. I completely uninstalled VS Code (after rebooting first to unlock the code.exe). Then I installed it again. Then I started VS Code again and code.exe was again locked by the System process.

Even more interesting: I just started Opera for fun, which is also installed in AppData\local\Programs\ and guess what, opera.exe has an invalid file handle attached to the System process. This matches what I have read in the (unfortunately closed) issues about someone mentioning Vivaldi.

So this seems more and more like a Windows (or whatever process can run with System privileges) issue and not a VS Code issue. I think it just became more prominent, when you decided to switch to the user space installation for VS Code as the preferred method.

Edit: just de-installed the user space installation (after rebooting first to unlock the code.exe) and installed the system-wide version. No such behavior in Process Explorer visible after closing VS Code.

[joaomoreno]

Merging this with #47841