Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align and change color in Start Menu icon #58893

Closed
diogoan opened this issue Sep 18, 2018 · 5 comments
Closed

Align and change color in Start Menu icon #58893

diogoan opened this issue Sep 18, 2018 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster
Milestone

Comments

@diogoan
Copy link

diogoan commented Sep 18, 2018

I'm not sure if this is a bug or a feature request, but I thought I should bring up this here.

When fixing VScode shortcut in Start Menu (Windows 10), the icon doesn't seem to be correctly aligned. That can be seen comparing with Visual Studio 2017 icon, for example:

image

Also, I have been using a blue tone in Windows theme for some time, when I installed/updated (don't remember exactly) VScode, which was using almost the same tone:

image

A suggestion would be to use a theme-independent icon, likewise Visual Studio 2017 icon, at the left.

Windows color I was using:
image

  • VSCode version: 1.27.2
  • Windows version: 1803
@octref
Copy link
Contributor

octref commented Sep 18, 2018

/cc @joaomoreno since you are more familiar with Windows. I thought we have icons of the same size as VS, but why are they smaller and showing up so low to the frame?

theme-independent icon, likewise Visual Studio 2017 icon, at the left.

If you make the tone purple, VS icon will be buried in the background color, correct? It seems there is no way to completely fix this.

@diogoan
Copy link
Author

diogoan commented Sep 18, 2018

If you make the tone purple, VS icon will be buried in the background color, correct? It seems there is no way to completely fix this.

No, because the background color in the VS icon is always black (or some kind of dark gray), no matter the color I choose in the Windows theme:

image

This is what I meant by "theme-independent icon".

@octref
Copy link
Contributor

octref commented Sep 18, 2018

I see, maybe we didn't specify a bg color so the system falls back to the "tone" you are using, which might bury our icon.

@joaomoreno joaomoreno removed their assignment Sep 19, 2018
@miguelsolorio miguelsolorio added the bug Issue identified by VS Code Team member as probable bug label Sep 24, 2018
@miguelsolorio miguelsolorio added this to the Backlog milestone Sep 24, 2018
@miguelsolorio
Copy link
Contributor

@diogoan can you provide more info on how you're setting the tile colors and if you're using any windows customizations? I'm also using Win10 1803 and am not able to repro:

image

image

@miguelsolorio miguelsolorio added the info-needed Issue requires more information from poster label Oct 1, 2018
@diogoan
Copy link
Author

diogoan commented Oct 3, 2018

@misolori I'm using vscode 1.27.2 on Win10 1803 too. I reinstalled vscode just to check how to reproduce and I'm not seeing the wrong icon/background again. Maybe that was corrected in a previous release?

image

I was using just an icon pack extension, but even installing it again, the icon is normal.
Thanks for the patience, if it happens again, I'll try to find what can be causing it to bring here.

@diogoan diogoan closed this as completed Oct 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

4 participants