New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All my text is black #60298
Comments
Fixed with a restart |
Restarting no longer fixing the issue. No extensions installed, settings are seldom changed except for theme. All dark themes have this issue |
Can you reproduce this using the Dark+ theme? What theme are you currently using? |
I'm using the Monokai theme, the issue appears with the Dark+ theme also |
Can you reproduce with vscode insiders? https://code.visualstudio.com/insiders/ |
@Patches- and opening chrome just a random website everything is rendered correctly? |
Sometimes when I open VSC it will have the white text as expected for a split second then it changes to black |
@Patches- does it reproduce if you run |
@bpasero Running that fixes the issue |
I'm still facing the issue here even with running |
@bpasero Thanks for following up. I have went with a better temporary solution. I added |
@fbalhawan That temporary solution worked for me as well |
More people seem to hit this, I wonder if this is due to the Windows October update. Do people have this installed? Adding another brain (@aeschli) to this to put in ideas. |
@fbalhawan @BartInTheField trying to understand if this is a regression from our 1.28 update, does it reproduce with the 1.27 build? Download |
@bpasero My text was fine in the 1.27 build |
I suspect there's a syntax error in the dynamic css that we generate.
This will copy our dynamic css to the clipboard. You can then paste what yoy get into the issue here or a gist Here's what I get: https://gist.github.com/aeschli/ee9fdbdb3a87c8ac1d4540aa91999bfe |
@bpasero as @BartInTheField said, it also worked for me when i tried the version 1.27 I have tried to do a comparison with a merging tool, but it wasn't that helpful for me |
@aeschli thank you, I think we are on the right path Looks like this CSS rule is causing issues: .monaco-workbench > .part.editor > .content .editor-group-container.empty .editor-group-letterpress {
background-image: url('c:/Users/Fouad's HP/AppData/Local/Programs/Microsoft VS Code/resources/app/resources/letterpress-dark.svg')
} @fbalhawan is your user name @BartInTheField what about your user name? I do not understand how this could have worked in 1.27. @fbalhawan can you do the same with 1.27 and paste the CSS value here? |
@bpasero lol! yup, that's my PC's username. I'm in a bit of a hurry and haven't read it, but it might be that the css element changing the color value of the menu text is written before the syntax error shown in version 1.27 |
@fbalhawan thanks, the issue exists in that version too but it is possible that we changed some order so that the impact is less noticeable. Meanwhile I am able to reproduce this by simply having a single quote in the folder from where I launch VSCode. It looks like this change fixes it: collector.addRule(`
.monaco-workbench > .part.editor > .content .editor-group-container.empty .editor-group-letterpress {
background-image: url('${CSS.escape(join(environment.appRoot, letterpress).replace(/#/g, '%23'))}')
}
`); @aeschli I am not 100% sure this is the right solution though, maybe you could confirm. When I do a search for |
@bpasero The sugget to turn the path in a URI and use toString |
Yes my username is 'Bartin'tVeld' so that seems to be the issue |
Ah yes that'll be my issue also then "C:\Users\Stephen O'Hara" |
Issue Type: Bug
After the update my text is now all black apart from on the files im editing. I have changed theme and its the same in most dark themes
VS Code version: Code 1.28.0 (431ef9d, 2018-10-05T14:58:53.203Z)
OS version: Windows_NT x64 10.0.17134
System Info
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
The text was updated successfully, but these errors were encountered: