Color preview/picker popup in CSS files shows black gradient for color #fe5e5f

[yura-chaikovsky]

Issue Type: Bug

Color popup shows black gradient for color #fe5e5f, while it is expected to be red.

VS Code version: Code 1.27.2 (f46c4c4, 2018-09-12T16:17:45.060Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz (4 x 2694)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	7.91GB (1.15GB free)
Process Argv	C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader	yes
VM	0%

Extensions (4)

Extension	Author (truncated)	Version
vetur	oct	0.13.0
vscode-docker	Pet	0.3.1
shader	sle	1.1.4
pegs	the	0.0.5

[DominoPivot]

I can confirm this is still an issue in the latest version (1.32.2 e64cb27).

[ndngo]

There seems to be an issue with how saturatedColor is calculated where sometimes certain values turn black.

For example, the colour #fd5e5f:

This is what the colour looks like before saturation.

After saturation:

After the saturation the colour turns black, so it displays black in the colour picker.

This bug also exists even when the colour picker renders the colour properly.
For example, the colour #fe5e4f:


In this case, the colour is rendered properly because the RGB values seem to be saturated correctly even though the HSV values are black.

[rebornix]

I think the deeper problem here is our color convert converts hsv(360, 1, 1) to rgb(0, 0, 0) instead of rgb(255, 0, 0).