Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"editor.autoClosingQuotes": "always" does not always apply #62968

Closed
mjbvz opened this Issue Nov 12, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@mjbvz
Copy link
Contributor

mjbvz commented Nov 12, 2018

Issue Type: Bug

Related to #61070

Repo

  1. Set "editor.autoClosingQuotes": "always"
  2. In a js file with cursor at |:
abc|
  1. Type ` (backtick)

Expected
Backtick is closed since we have set the mode to always

Actual
Quote is not closed

VS Code version: code-oss-dev 1.30.0 (Commit unknown, Date unknown)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 3, 3
Memory (System) 16.00GB (0.08GB free)
Process Argv .
Screen Reader no
VM 25%
@5tormTrooper

This comment has been minimized.

Copy link

5tormTrooper commented Mar 19, 2019

I still have this issue.
Applied the setting, and even tried reloading window with extensions disabled. Tried in both "javascript" and "javascriptreact".

VS Code: 1.32.3 (1.32.3)
OS: MacOS High Sierra 10.13.6

@irrationalRock

This comment has been minimized.

Copy link
Contributor

irrationalRock commented Apr 1, 2019

@5tormTrooper I'm wondering if can you try and replicate this issue on VSCode Insiders?

@5tormTrooper

This comment has been minimized.

Copy link

5tormTrooper commented Apr 7, 2019

@irrationalRock It seems to autoclose as expected on Insiders 👍

However, it'd be helpful to have it auto-indent on enter, since template literals allow expressions, such as in use with graphql.

Screen Recording 2019-04-07 at 12 25 PM

VS Code: 1.34.0-insider (1.34.0-insider)

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.