tittle bar custom is not working

[aeb-dev]

Custom title bar is not showing.

Version: 1.30.0-insider (user setup)
Commit: cd5b4d1
Date: 2018-11-29T06:32:54.872Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
OS: Windows_NT x64 10.0.17134

It is now like this:

It was like this:

Title bar style:

Does this issue occur when all extensions are disabled?: Yes

[sbatten]

@Mrmumu Can you verify that window.smoothScrollingWorkaround is not enabled on the problematic build. It is incompatible with the custom titlebar

[aeb-dev]

@sbatten it was enabled, it is fixed when I disabled it. However it was working before when it was enabled. Is there a specific reason for disabling it?

[sbatten]

@Mrmumu the smooth scrolling workaround does not work when the custom title bar is enabled and a recent refactor introduced this check

[aeb-dev]

thank you for explanation, have a nice day, closing the issue.

[SoraYama]

@sbatten Hmm, I found that if window.nativeFullScreen is disabled on macOS v1.30, the titlebar cannot display as custom style, which works properly in before versions.

[lochstar]

@SoraYama Exact same issue. The custom titlebar is now just an empty row on macOS. It was working fine in the previous release. I do not have window.smoothScrollingWorkaround enabled as mentioned in #64969.

[sbatten]

@lochstar see comment #64967 (comment)

[morissonmaciel]

This breaking change in titleBarStyle vs. smoothScrollingWorkaround should be documented or properly addressed prior release.
Or, better, the message displayed prior restart on titleBatStyle change, should inform conflict with the smoothScrollingWorkaround setting.