Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The whole treeview is rerendered when an update event being triggerred #64557

Closed
rebornix opened this issue Dec 6, 2018 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority tree-views Extension tree view issues verified Verification succeeded
Milestone

Comments

@rebornix
Copy link
Member

rebornix commented Dec 6, 2018

Issue Type: Bug

  • Install GH PR or GitLens
  • Go to a tree view contributed by the extension, hit refresh button on the title
  • The whole tree view is rerendered.

VS Code version: Code - Insiders 1.30.0-insider (048fdbb, 2018-12-06T06:17:10.993Z)
OS version: Windows_NT x64 10.0.17134

refresh-treeview

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 3600)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 31.92GB (10.75GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (10)
Extension Author (truncated) Version
vscode-eslint dba 1.7.0
gitlens eam 9.0.3
tsl-problem-matcher eam 0.0.4
tslint eg2 1.0.40
vscode-pull-request-github-insiders Git 0.338.0
Angular2 joh 7.0.1
vscode-typescript-tslint-plugin ms- 0.1.1
debugger-for-chrome msj 4.11.1
toggle reb 0.0.1
vscodeintellicode Vis 1.1.0

(4 theme extensions excluded)

@vscodebot vscodebot bot added the insiders label Dec 6, 2018
@rebornix rebornix added important Issue identified as high-priority and removed insiders labels Dec 6, 2018
@sandy081 sandy081 added tree-views Extension tree view issues bug Issue identified by VS Code Team member as probable bug labels Dec 6, 2018
@sandy081 sandy081 added this to the November 2018 milestone Dec 6, 2018
@sandy081
Copy link
Member

sandy081 commented Dec 6, 2018

@rebornix Good catch

This was caused because of #63906. I am hiding the tree container when it is empty so that there is only focusable container for message.

Fix is to hide tree only when there is a message and tree is not refreshing and empty.

@sandy081
Copy link
Member

sandy081 commented Dec 6, 2018

Verify that views with and without message are getting refreshed without getting hidden. Use References List and Github PR tree for testing.

@RMacfarlane RMacfarlane added the verified Verification succeeded label Dec 7, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants