Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve experience for really long settings descriptions #66184

Closed
Tyriar opened this issue Jan 7, 2019 · 7 comments
Closed

Improve experience for really long settings descriptions #66184

Tyriar opened this issue Jan 7, 2019 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 7, 2019

After #66179 馃槺

image

Some options:

  • Have a read more button when things get too long
  • Have string that appear only in the JSON/intellisense
@roblourens roblourens added feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Jan 7, 2019
@roblourens roblourens added this to the December/January 2019 milestone Jan 7, 2019
@roblourens
Copy link
Member

roblourens commented Jan 24, 2019

I want to add JSON schema properties, uiDescription and uiMarkdownDescription, which will let us override the normal description for just the settings UI. The description with the full list will still show up in the JSON editor and the suggest widget. Thoughts on that @aeschli?

I think that in the future we could have a control that would let us show the default value in a better way in the UI editor.

I don't really like the "read more" button as a one-off workaround for this setting.

@aeschli
Copy link
Contributor

aeschli commented Jan 25, 2019

@roblourens Can't we find a (markdown)description that works in both UI and intellisense?
IMO we can tune the settings descriptions for the UI, the intellisense experience is now less important

@Tyriar
Copy link
Member Author

Tyriar commented Jan 25, 2019

@aeschli the full list needs to be accessible somewhere so that users know what to add/remove, adding this to the website would be awkward as it changes between versions and would need to be updated manually. The separate descriptions proposed makes sense here because you can't even edit the setting in the UI.

screen shot 2019-01-25 at 8 32 29 am

@roblourens how about a truncateMarkdownDescription: boolean flag instead which truncates after x characters on the UI?

@roblourens
Copy link
Member

How about I just always truncate after x newline characters and add a [...] rather than an expand button. And counting newlines instead of figuring out wrapped lines. That should only impact this one setting.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 26, 2019

@roblourens great idea 馃憤

@dbaeumer dbaeumer added the verification-needed Verification of issue is requested label Jan 29, 2019
@sandy081 sandy081 added the verified Verification succeeded label Jan 30, 2019
@tiliv
Copy link

tiliv commented Feb 22, 2019

Hey all, I'm finding this change really complicated to deal with. When I copy the default setting to put in my own, it's empty, so the truncation makes this a very confusing setting to work with.

Am I missing something about the intended interaction with this setting's value?

@roblourens
Copy link
Member

You only need to add settings that you want to add or remove from the list. If you want to see the full list for reference, you should be able to see the full list when you hover the setting name in the json editor.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants