Workbench › List: Keyboard Navigation settings polish

[isidorn]

1. Explain better in setting value description what each setting does.
2. Filled Settings search does not search within values #66893. In case that does not get fixed consider adding word "filter" to the settings description

[isidorn]

workbench.list.keybaordNavigation: Controls the keyboard navigation style for lists and trees in the workbench. Can be simple, highlight and filter.
simple: Simple keyboard navigation focuses elements which match the keyboard input. Matching is done only on prefixes.
highlight: Highlight keyboard navigation highlights elements which match the keyboard input. Further up and down navigation will traverse only the highlighted elements.
filter: Filter keyboard navigation will filter out and hide all the elements which do not match the keyboard input.

fyi @weinand @bpasero on potential ideas for better wording

[bpasero]

I find the name keybaordNavigation weird as setting, to me this implies normal navigation without filtering. Should it not rather be workbench.list.filtering? That is the setting name I would look out for when caring about filtering in trees.

[joaomoreno]

@bpasero When the setting is set to highlight, there's no filtering at all.

[bpasero]

maybe workbench.list.search? searchNavigation?

[joaomoreno]

When it's set to simple, there's no search, only navigation.

[isidorn]

Note that the feature request which got 300+ upvotes had the following key words:
Navigate, explorer, typing. This means that a lot of people could find it in github search easily
#10026

Due to that I like that we use the word navigation to describe the setting
workbench.list.keyboardNavigation or workbench.list.typeToNavigate would work for me

The only thing I would do is add the world explorer in the setting description, so people that search for navigation and explorer actually get this setting.

[a-eid]

I used to navigate up and down with j and k, after the latest update 1.31 it doesn't work any more, none of the options give what I want. is there a way to revert to the way it used to act before the update?

[bpasero]

@a-eid are you using any extension for those keybindings or are they custom assigned by you?

[a-eid]

@bpasero I use VSCodeVim.

[bpasero]

@a-eid on which version are you, did you update to 1.0.7 at least?

[a-eid]

@bpasero I'm at 1.0.8.

[bpasero]

@a-eid and in which tree are you seeing this issue?

[a-eid]

what do u mean which tree? @bpasero

[bpasero]

@a-eid you said "I used to navigate up and down with j and k", do you mean the file explorer in the side bar?

[a-eid]

@bpasero yes.

[a-eid]

it buffers what I type up top to the right, playing with the workbench.list.keyboardNavigation option does yield different results, but not the one I'm used to.

[bpasero]

Ok thanks, I am confused why you hit this, I thought this was fixed via https://github.com/VSCodeVim/Vim/blob/master/CHANGELOG.md#v107-2019-02-02 (VSCodeVim/Vim#3432)

//cc @joaomoreno @jpoon

[Nodman]

@a-eid I had the same issue, fixed it by choosing "simple" in Workbench › List: Keyboard Navigation

[nosajio]

Same issue here but without any additional extensions. The conflict is very annoying if you use the keyboard to navigate files. But I'd like to be able to turn on filtering because it's useful.

Maybe an option to configure a trigger would be a good way to fix this?

[joeynguyen]

I'm sure a lot of users find this feature useful and kudos to the devs for making it happen for them, but in the future can I ask that new features like this PLEASE be opt-in by default instead of opt-out? Like several of the users here, having it enabled by default really threw off my workflow, causing frustration. I customized my own keybindings to allow me to navigate the Explorer using Vim NERDTree-style shortcuts and this feature caused conflicts with it. I had to go into the Issues tab of this repo to find out how to resolve it because I figured others were experiencing the same thing.

Thanks for all the great work!