Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Organize Imports' runs after code formatters and after file was saved #68193

Closed
paustint opened this issue Feb 8, 2019 · 2 comments
Closed
Assignees
Labels
*caused-by-extension Issue identified to be caused by an extension

Comments

@paustint
Copy link

paustint commented Feb 8, 2019

  • VSCode Version: 1.31.0
  • OS Version: OSX 10.14.2

Steps to Reproduce:

  1. Install prettier extension
  2. Enable format on save
  3. Enable organize imports on save
  4. Create typescript file with lots of imports, causing prettier (or any other code formatter) to move imports onto individual lines
  5. Save file (ensure that code formatter runs on save)
    • prettier formats code
    • Organize imports are performed after code is formatted ;(
    • File is saved to disk
    • THEN imports are organized again
      • The file remains dirty (white circle showing file was modified since last save)
      • The imports modified by the code formatter were completely ignored

This started happening immediately after updating to 1.31.0 and worked fine before that, and I have not made any setting changes or added/removed any extensions since the update.

Does this issue occur when all extensions are disabled?: Yes/No Probably not, since the native code on 1.31.0 conflicts with extensions, but it is core VSCode that changed

vscode-auto-import-after-save

@vscodebot vscodebot bot added the new release label Feb 8, 2019
@mjbvz mjbvz added the *caused-by-extension Issue identified to be caused by an extension label Feb 9, 2019
@vscodebot
Copy link

vscodebot bot commented Feb 9, 2019

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Feb 9, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Feb 9, 2019

Please start by filing an issue with the Prettier extension

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension
Projects
None yet
Development

No branches or pull requests

2 participants