Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display color error after newest release on surface #68854

Closed
vomyrak opened this issue Feb 16, 2019 · 5 comments
Closed

Display color error after newest release on surface #68854

vomyrak opened this issue Feb 16, 2019 · 5 comments
Assignees
Labels
electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@vomyrak
Copy link

vomyrak commented Feb 16, 2019

Since the latest update, the colour display of my vscode on surface is very wrong. The default colour scheme now look like this
20190216202914
In fact the display of all themes are wrong, just another example:
20190216205429

Reinstallation and reset settings have no effect.

@vomyrak
Copy link
Author

vomyrak commented Feb 16, 2019

I'm using surface pro 5 running windows 10 17134.590. No issue is observed on my other pc running the same system

@vomyrak
Copy link
Author

vomyrak commented Feb 17, 2019

Update: Rolling back to version 1.30.2 the problem disappears, but if I try to update again to 1.31.1 the same problem is reproduced.

@bpasero
Copy link
Member

bpasero commented Feb 18, 2019

We are building exploration builds that use a much newer version of our UI framework (Electron version 4.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download:

@bpasero bpasero self-assigned this Feb 18, 2019
@bpasero bpasero added the info-needed Issue requires more information from poster label Feb 18, 2019
@vomyrak
Copy link
Author

vomyrak commented Feb 18, 2019

No, the problems are not reproduced with the windows exploration build

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron fixed-in-electron-4.0.x and removed info-needed Issue requires more information from poster labels Feb 18, 2019
@bpasero
Copy link
Member

bpasero commented Jul 1, 2019

We will ship with Electron 4 with our upcoming release 1.36 this week. As such I am closing this issue. To benefit from the update already today, consider to use our insiders version: https://code.visualstudio.com/insiders/

@bpasero bpasero closed this as completed Jul 1, 2019
@bpasero bpasero added this to the June 2019 milestone Jul 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants