Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry: We should log startup times #707

Closed
bpasero opened this issue Nov 26, 2015 · 4 comments
Closed

Telemetry: We should log startup times #707

bpasero opened this issue Nov 26, 2015 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Nov 26, 2015

We had a severe performance regression in startup time (#335). For the future it would be cool to log the startup time via telemetry and then to see trends between versions to see if we are getting slower or better over time.

@sofianhn this would need to be done from the main side I guess because you dont want to log it for each window open. We already have the starting time stored here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-main/bootstrap.js#L9

@egamma @alexandrudima fyi we talked about it

@alexdima
Copy link
Member

@bpasero
But the regression in start-up time was in the renderer side, (on each window open), so I don't think logging from the main process would have helped discover it sooner. Logging the startup time of the main process would also be useful.

@bpasero
Copy link
Member Author

bpasero commented Nov 26, 2015

@alexandrudima sorry I was not clear: yes, we must log all the time it takes until the first workbench window is up and running. what I meant is that this logging code should live on the main side and not renderer side because only main side knows when the first window is opening!

@sofianhn sofianhn added the feature-request Request for new features or functionality label Nov 29, 2015
@bpasero
Copy link
Member Author

bpasero commented Dec 2, 2015

@sofianhn I added event name startupTime and value { ellapsed: number }. We should hook this up to our dashboard after releasing.

@bpasero bpasero closed this as completed in 65d8505 Dec 2, 2015
@bpasero bpasero assigned bpasero and unassigned sofianhn Dec 2, 2015
@bpasero bpasero added this to the Dec 2015 milestone Dec 2, 2015
@sofianhn
Copy link

sofianhn commented Dec 2, 2015

@bpasero thanks! I will add that to the dashboard.

@egamma egamma mentioned this issue Dec 2, 2015
34 tasks
@egamma egamma mentioned this issue Jan 6, 2016
59 tasks
@bpasero bpasero added the verified Verification succeeded label Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants