Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated terminal does not launch when project folder contains special/unicode characters #7727

Closed
VitorLuizC opened this issue Jun 15, 2016 · 33 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@VitorLuizC
Copy link

  • VSCode Version: 1.3.0-insider
  • OS Version: Windows 10 Home

Gif

Steps to Reproduce:

  1. Open a folder with special characters;
  2. Try to open the integrated Terminal;
@Tyriar
Copy link
Member

Tyriar commented Jun 15, 2016

@VitorLuizC can you paste in some of the problem characters? Also do you have any terminal-specific settings set in your settings.json?

@Tyriar Tyriar self-assigned this Jun 15, 2016
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster terminal Integrated terminal issues labels Jun 15, 2016
@VitorLuizC
Copy link
Author

My folder's name is "Paçoca", so the "ç" is the only special character, and no I didn't have any terminal-specific settings in my settings.json.

settings.json screenshot

I've tried to open integrated terminal in another folder without special characters("Pacoca") and it worked.

@Tyriar
Copy link
Member

Tyriar commented Jun 15, 2016

Seems fine on stable and insiders on Linux:

image

Perhaps it's only happening on Windows?

@Tyriar Tyriar added windows VS Code on Windows issues and removed info-needed Issue requires more information from poster labels Jun 15, 2016
@VitorLuizC
Copy link
Author

VitorLuizC commented Jun 15, 2016

I don't know if it matters but that folder is inside my OneDrive folder.

Folder's path


After a new test i've checked that doesn't matter.

@ZCShou
Copy link

ZCShou commented Jun 16, 2016

Chinese folder or Japanese folder so does on Windows 10!!

@Tyriar
Copy link
Member

Tyriar commented Jun 16, 2016

Must be a windows thing, I'll try have a look at this for v1.3

@Tyriar Tyriar added this to the June 2016 milestone Jun 16, 2016
@hakanostrom
Copy link

hakanostrom commented Jun 17, 2016

Can confirm it effects on a new installation of v1.2.1 and on windows.
Folders causing this for me is when opened as "root" and containing swedish letters (åäö). Also if folders above "root" contains special characters.

@Tyriar
Copy link
Member

Tyriar commented Jun 17, 2016

I had a look at this and it appears to be an upstream issue, moving to backlog.

@Tyriar Tyriar modified the milestones: Backlog, June 2016 Jun 17, 2016
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jun 17, 2016
@joseph-iussa
Copy link

Can confirm this is happening for me as well (just updated to 1.2.1 and currently on Windows 10). Behaviour is exactly as shown in VitorLuizC's image, except that I have no special characters in my path, and in fact the problem still occurs with no folders or files open and just the initial untitled document displayed.

I recently upgraded to Windows 10 from Windows 7 and the problem was not present while on Windows 7.

@svekl
Copy link

svekl commented Jul 7, 2016

For me it happens for russian characters, I have "Сергей" in path on Win 10

@Tyriar Tyriar changed the title Terminal quickly toggle when the project folder has special characters Integrated terminal does not launch when project folder contains special/unicode characters Jul 11, 2016
@xmichaelx
Copy link

Confirm for polish letters in path on Windows 10.

@hs3180
Copy link

hs3180 commented Jul 24, 2016

+1 for Chinese

@Igmat
Copy link

Igmat commented Jul 26, 2016

+1 for Russian on Windows 10. It doesn't matter are there any special characters in path for opened by VSCode folder. Having them in Windows username will be enough to get integrated-terminal crashing.

@osnoser1
Copy link

Not only special chars, i think that are all unicode characters.
My user folder is 'Alfonso Andrés'.
Windows 10.

@Dzienny
Copy link

Dzienny commented Sep 18, 2016

I encountered this problem today. I think I found the culprit. The vscode uses pty.js to open the terminal. https://github.com/Microsoft/vscode/blob/a6c845baf7fed4a186e3b744c5c14c0be53494fe/src/vs/workbench/parts/terminal/electron-browser/terminalProcess.js (line: 30)

And on the pty.js project I found the following open issue: chjj/pty.js#173

@Tyriar
Copy link
Member

Tyriar commented Sep 18, 2016

@Dzienny yes it could be either pty.js or the dated winpty version it uses.

@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Sep 19, 2016
@Tyriar Tyriar modified the milestones: Backlog, September 2016 Sep 19, 2016
@the-ress
Copy link
Contributor

I've created a pull request with the fix here: chjj/pty.js#176

@Tyriar
Copy link
Member

Tyriar commented Oct 12, 2016

Fixed thanks to @the-ress's pull request! You can try this out in the Insiders build tomorrow or in stable v1.7.

@srcnalt
Copy link

srcnalt commented Nov 22, 2016

I am facing this error on Linux Solus. No special character on file dir. When I try to compile code (alt+enter) F# Interactive console appears for a moment then I get this error message.

@Tyriar
Copy link
Member

Tyriar commented Nov 22, 2016

@srcnalt make sure you're on the latest version, if you still experience the issue please file a new one via Help > Report Issues 😃

@4e1e0603
Copy link

4e1e0603 commented Mar 11, 2017

I have the same issue: The terminal process command FsiAnyCpu.exe --fsi-server-input-codepage:65001 failed to launch (exit code: 3221225477)

My path to the folder is without any accents or special characters.

  • VSCode Version: Code 1.10.2 (8076a19, 2017-03-08T14:02:52.799Z)
  • OS Version: Windows_NT ia32 6.1.7601
  • Extensions:
Extension Author Version
Ionide-fsharp Ionide 2.23.9

@dfilaretti
Copy link

Exact same problem here with Ionide on windows 10. Have tried on windows 7 and it works.
Do not have any accents or special chars.

@devmattrick
Copy link

Sorry to bump, but I'm not sure if this is related.

When I run rollup -w I get the "The terminal process terminated with exit code" error, but the error code is 259, strangely. Running it in git bash outside of VSCode works fine, but the integrated terminal crashes without fail.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests