Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in type definition #13159

Merged
merged 1 commit into from
Oct 3, 2016
Merged

Conversation

michaelchiche
Copy link
Contributor

No description provided.

@mention-bot
Copy link

@michaelchiche, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dbaeumer to be a potential reviewer.

@msftclas
Copy link

msftclas commented Oct 3, 2016

Hi @michaelchiche, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@michaelchiche michaelchiche changed the title fix typo in type definitiion fix typo in type definition Oct 3, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.221% when pulling 261c23d on michaelchiche:patch-1 into a0b0fd9 on Microsoft:master.

@waderyan waderyan merged commit 555b4f0 into microsoft:master Oct 3, 2016
@michaelchiche michaelchiche deleted the patch-1 branch October 3, 2016 18:00
@dbaeumer
Copy link
Member

dbaeumer commented Oct 4, 2016

@michaelchiche thanks a lot for the PR. However this code is owned by the TypeScript team and we consume this through npm (although currently checked into our repository). So you need to file the PR here: https://github.com/Microsoft/TypeScript

@michaelchiche
Copy link
Contributor Author

michaelchiche commented Oct 4, 2016

@dbaeumer I just did the PR on the Typescript repo:

microsoft/TypeScript/pull/11346

@bpasero bpasero modified the milestone: October 2016 Oct 28, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants