Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing test coverage for collections #13817

Merged

Conversation

jchadwick
Copy link
Contributor

Another set of tests to increase coverage for core functionality

@mention-bot
Copy link

@jchadwick, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma to be a potential reviewer.

@msftclas
Copy link

Hi @jchadwick, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@jchadwick
Copy link
Contributor Author

As mentioned in PR #13792:

I'm interested and eager to write more unit tests. Please let me know if there are any areas that you would prefer that I focus on (right now I'm just looking at anything called "core").

Also, let me know how to submit the PRs - one test fixture per PR, a bunch at a time, or...?

Happy to help out. Just let me know what you need.

CC @alexandrudima

@jrieken
Copy link
Member

jrieken commented Oct 17, 2016

Thanks

@jrieken jrieken merged commit c7c960e into microsoft:master Oct 17, 2016
@bpasero bpasero modified the milestone: October 2016 Oct 28, 2016
@jchadwick jchadwick deleted the jchadwick/codecoverage/collections branch February 3, 2017 19:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants