Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GConf2 dependency in rpm spec template #16016

Merged
merged 1 commit into from
Dec 14, 2016
Merged

Conversation

xadhoom
Copy link
Contributor

@xadhoom xadhoom commented Nov 24, 2016

Fixes #16015

@mention-bot
Copy link

@xadhoom, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Tyriar, @polygotdev and @astitcher to be potential reviewers.

@msftclas
Copy link

Hi @xadhoom, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@@ -9,6 +9,7 @@ License: MIT
URL: https://code.visualstudio.com/
Icon: @@NAME@@.xpm
Requires: glibc >= 2.15
Requires: GConf2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Will this work for both 32 and 64 bit across most distributions? We had some issues with libXss.so.1 where installation failed because the package was not found in the local package manager..

Copy link
Contributor Author

@xadhoom xadhoom Nov 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because I'm mentioning a package name and not a library name.
When you mention a package name, if you omit the arch, the current system arch will be used.
(is also possible to force the arch on a package dep but I'm not doing it on purpose).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with libXss though was that the package name differed depending on the OS, some were libXss, some were libXScrnSaver I believe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we actually want to do what we do for libXss.so.1 here and have a separate one for 64-bit and 32-bit:

libgconf-2.so.4

libgconf-2.so.4()(64bit)

Chromium seems to do it this way in https://cs.chromium.org/chromium/src/chrome/installer/linux/rpm/expected_deps_x86_64?dr=C&sq=package:chromium

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll follow up with this, thanks for the contribution 😄

@Tyriar Tyriar modified the milestones: January 2017, November 2016 Dec 14, 2016
@Tyriar Tyriar merged commit d9f50bd into microsoft:master Dec 14, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants