Add GConf2 dependency in rpm spec template #16016

Merged
merged 1 commit into from Dec 14, 2016

Projects

None yet

4 participants

@xadhoom
Contributor
xadhoom commented Nov 24, 2016

Fixes #16015

@xadhoom xadhoom Add GConf2 dependency in rpm spec template
42b9343
@mention-bot

@xadhoom, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Tyriar, @polygotdev and @astitcher to be potential reviewers.

@msftclas

Hi @xadhoom, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@Tyriar Tyriar was assigned by jrieken Nov 24, 2016
@Tyriar Tyriar added this to the November 2016 milestone Nov 24, 2016
@@ -9,6 +9,7 @@ License: MIT
URL: https://code.visualstudio.com/
Icon: @@NAME@@.xpm
Requires: glibc >= 2.15
+Requires: GConf2
@Tyriar
Tyriar Nov 29, 2016 Member

Thanks for the PR! Will this work for both 32 and 64 bit across most distributions? We had some issues with libXss.so.1 where installation failed because the package was not found in the local package manager..

@xadhoom
xadhoom Nov 29, 2016 edited Contributor

Yes, because I'm mentioning a package name and not a library name.
When you mention a package name, if you omit the arch, the current system arch will be used.
(is also possible to force the arch on a package dep but I'm not doing it on purpose).

@Tyriar
Tyriar Nov 30, 2016 Member

The problem with libXss though was that the package name differed depending on the OS, some were libXss, some were libXScrnSaver I believe.

@Tyriar
Tyriar Dec 13, 2016 Member

I think we actually want to do what we do for libXss.so.1 here and have a separate one for 64-bit and 32-bit:

libgconf-2.so.4

libgconf-2.so.4()(64bit)

Chromium seems to do it this way in https://cs.chromium.org/chromium/src/chrome/installer/linux/rpm/expected_deps_x86_64?dr=C&sq=package:chromium

@Tyriar
Tyriar Dec 14, 2016 Member

I'll follow up with this, thanks for the contribution 😄

@Tyriar Tyriar modified the milestone: January 2017, November 2016 Dec 14, 2016
@Tyriar Tyriar merged commit d9f50bd into Microsoft:master Dec 14, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment