-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GConf2 dependency in rpm spec template #16016
Conversation
@xadhoom, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Tyriar, @polygotdev and @astitcher to be potential reviewers. |
Hi @xadhoom, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
@@ -9,6 +9,7 @@ License: MIT | |||
URL: https://code.visualstudio.com/ | |||
Icon: @@NAME@@.xpm | |||
Requires: glibc >= 2.15 | |||
Requires: GConf2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Will this work for both 32 and 64 bit across most distributions? We had some issues with libXss.so.1
where installation failed because the package was not found in the local package manager..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because I'm mentioning a package name and not a library name.
When you mention a package name, if you omit the arch, the current system arch will be used.
(is also possible to force the arch on a package dep but I'm not doing it on purpose).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with libXss
though was that the package name differed depending on the OS, some were libXss
, some were libXScrnSaver
I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we actually want to do what we do for libXss.so.1
here and have a separate one for 64-bit and 32-bit:
libgconf-2.so.4
libgconf-2.so.4()(64bit)
Chromium seems to do it this way in https://cs.chromium.org/chromium/src/chrome/installer/linux/rpm/expected_deps_x86_64?dr=C&sq=package:chromium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll follow up with this, thanks for the contribution 😄
Fixes #16015