Add a few niceties for making Flatpak builds of VSCode #17370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This honors the following environment variables: - $GPG_KEY_ID: When set, it can be the identifier, full fingerprint, or email address of a GnuPG key which will be used to sign Flatpak builds. - $GPG_HOMEDIR: Path to an alternative home directory to be used by GnuPG, instead of the default ~/.gnupg directory of the current user. This can be used to point GnuPG to a different keychain.
This makes the Flatpak builds honor the $FLATPAK_REPO environment variable. When it is defined, it will be used as the path to an OSTree repository where the Flatpak application bundle will be committed to. This allows to place multiple builds in the same repository (along other applications, even), which can be published. For more details abuit using repositories for publishing, check: http://flatpak.org/developer.html#Distributing_Applications Note that setting $FLATPAK_REPO disables building a standalone .flatpak bundle file.
When storing the output of a Flatpak build to a commit into an OSTree repository (by setting the $FLATPAK_REPO environment variable), it is good to have a descriptive subject in the commit log message.
|
Hi @aperezdc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
|
That was fast! Thanks for merging this 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following:
Rationale
Flatpak includes support for fetching applications from a repository (which may contain multiple applications and runtimes), and updates pushed to the repository are automatically picked by application managers like GNOME Software or when using the
flatpak updatecommand.More Info
Additional reasons why one would want to prefer a repository over serving a bunch of
.flatpakfiles:flatpak-buildertool (called under the hood by theflatpak-bundlerJS module) is building a.flatpaksingle-file bundle, it will first commit the built files into a temporary OSTree repository and then export that single commit to the.flatpakfile. Using$FLATPAK_REPOjust skips the latter..flatpakreffile in GNOME Software, which will have the application installed and the repository configured in one go. This is nice to ensure the users will get updates (see “Referring to repositories” in the Flatpak documentation for details).This is a follow-up to PR #16169 and a complement to issue #7112.