Markdown fixes #18704

Merged
merged 4 commits into from Jan 20, 2017

Projects

None yet

5 participants

@morags
Contributor
morags commented Jan 18, 2017

Added several languages and fixed a typo in markdown.tmLanguage.

morags added some commits Jan 17, 2017
@morags morags Fix typos 02202bc
@morags morags Add Go, Rust and Scala
ad7f512
@msftclas

Hi @morags, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@kieferrm kieferrm was assigned by dbaeumer Jan 18, 2017
@msftgits

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@msftgits msftgits closed this Jan 18, 2017
@msftgits msftgits reopened this Jan 18, 2017
@msftclas

Hi @morags, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@msftclas msftclas added the cla-signed label Jan 18, 2017
@msftgits msftgits removed the cla-required label Jan 18, 2017
@mjbvz mjbvz self-assigned this Jan 19, 2017
@@ -2404,6 +2431,38 @@
</dict>
</array>
</dict>
+ <key>fenced_code_block_rust</key>
@mjbvz
mjbvz Jan 19, 2017 Contributor

Please update these to use the fenced code block logic that the other languages now use. It's rather horrific but it fixes a few important edge cases

morags added some commits Jan 20, 2017
@morags morags Merge branch 'master' of https://github.com/Microsoft/vscode into mor…
…ags/markdown_fixes
f129a7a
@morags morags Adjust Go, Rust and Scala's logic as per #17591
6999eeb
@mjbvz mjbvz added this to the January 2017 milestone Jan 20, 2017
@mjbvz mjbvz merged commit 22cc4a1 into Microsoft:master Jan 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mjbvz
Contributor
mjbvz commented Jan 20, 2017

Thank you for these improvements. They should be in the next insiders build

@morags
Contributor
morags commented Jan 20, 2017

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment