Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Enabled View to Extension Viewlet #25974

Closed
wants to merge 3 commits into from

Conversation

gonzofish
Copy link

Addresses #22866

Added Enabled action to extensions viewlet
Added "Extensions: Show Enabled Extensions" action to workbench
Set showing enabled in extensions to default view when opening extensions viewlet

Matt Fehskens added 2 commits May 4, 2017 23:24
Set it to default extensions pane to enabled
Added action to command palette as well
@mention-bot
Copy link

@gonzofish, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @joaomoreno to be potential reviewers.

@msftclas
Copy link

msftclas commented May 5, 2017

@gonzofish,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link

msftclas commented May 5, 2017

@gonzofish, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@joaomoreno joaomoreno self-assigned this May 5, 2017
@joaomoreno joaomoreno added this to the May 2017 milestone May 5, 2017
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that the user can filter out the disabled extensions. But I don't think that should be the default behaviour. I would keep the @installed view as the default behaviour.

@gonzofish
Copy link
Author

gonzofish commented May 5, 2017 via email

@joaomoreno joaomoreno modified the milestones: May 2017, June 2017 May 24, 2017
@leocaseiro
Copy link

I was wondering if this feature is ready to be merged.

I'm happy to give some help.

Thanks

@gonzofish
Copy link
Author

Yeah me too. I updated it as requested but never heard anything after.

@sandy081
Copy link
Member

@gonzofish Sorry for not looking into this.. I will take a look.. But may I know is it possible to resolve the conflicts?

@gonzofish
Copy link
Author

@sandy081 no worries! I hadn't noticed the conflicts. I can definitely fix them today.

@joaomoreno joaomoreno modified the milestones: June 2017, Backlog Jun 26, 2017
@leocaseiro
Copy link

leocaseiro commented Jul 6, 2017

Hi @gonzofish, I don't want to be "push", so I was wondering If you could give me access to this branch, so I can help fixing the conflicts, in case you've been busy.

Thanks

@BuraChuhadar
Copy link
Contributor

BuraChuhadar commented Jul 11, 2017

@sandy081 this is #30367 on top of @gonzofish's changes which only fixes the merge conflicts.

@sandy081
Copy link
Member

@bugrac Thanks. Will take a look.

@sandy081 sandy081 modified the milestones: July 2017, Backlog Jul 11, 2017
@gonzofish
Copy link
Author

@bugrac thanks for updating in my absence

I had some things come up and was away from Internet access for the last week, sorry for the radio silence

@joaomoreno joaomoreno assigned sandy081 and unassigned joaomoreno Jul 24, 2017
@sandy081
Copy link
Member

@gonzofish Merged the PR from @bugrac.

@sandy081 sandy081 closed this Jul 25, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants