Add bottom padding to integrated terminal. Fixes #30626 #30728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Jul 14, 2017
| @@ -29,6 +29,7 @@ | |||
| position: absolute; | |||
| bottom: 0; | |||
| top: 0; | |||
| padding-bottom: 2px; | |||
There was a problem hiding this comment.
Does bottom: 2px here save us from doing the changes in terminalInstance.ts?
There was a problem hiding this comment.
I tried quite a bit of combinations of both margin and padding as well as trying to change the positioning.
I was unable to use just position-bottom, this threw everything off.
even if we used bottom I believe we would still have to do the inner height adjustment so I'm not sure if the change is if I'm understanding you.
|
@cleidigh looks good, I removed some comments as I feel they're just necessary to explain in the PR itself 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tyriar
this was not possible given that the terminal wrapper is absolutely located to the bottom
of the terminal outer container.
Fixes #30626