New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the terminal and find widget key presses #33935

merged 1 commit into from Sep 11, 2017


None yet
3 participants

ihalip commented Sep 7, 2017

This should fix #30994 and #33833.

This function was added in this commit, which fixed an interaction with the Esc key when the terminal find widget was visible.

I tried multiple scenarios with the Ctrl+A, Ctrl+V, Esc keys (both in the terminal and editor, with the find widget opened or closed) and I don't think there are any regressions.

CC @Tyriar


This comment has been minimized.

Show comment
Hide comment

Tyriar Sep 11, 2017


Seems to work great! Thanks 😄


Tyriar commented Sep 11, 2017

Seems to work great! Thanks 😄

@Tyriar Tyriar added this to the September 2017 milestone Sep 11, 2017


Tyriar approved these changes Sep 11, 2017

@Tyriar Tyriar merged commit 48bfb73 into Microsoft:master Sep 11, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
license/cla All CLA requirements met.

@ihalip ihalip deleted the ihalip:fix-30994 branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment