Fixes #36544. #36578
Merged
Fixes #36544. #36578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was definitely a bug in my "Go Last" implementation, but it was only exposed by using 499086d (and/also 273dbee) which made more aggressive use of the
addOrReplaceInStackmethod.The problem is that when the navigation stack is full, the array is shifted over and indexes are patched up. This can result with a lastIndex that exceeds the length of the array, since
setIndexwas being called twice during the patch up with inconsistent array lengths. The fix is to only call setIndex once, after the length is corrected. This also fixes a bug in "Go Last" where the "last" position is wrong if it's notthis.stack.length - 1after the history buffer fills up. To fix that, we slide thelastIndexover along with the array unshift. If the last index falls off the left side of the array, it will be -1, which is already handled bylast()to fallback to the behavior ofback().