Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the UTI types for files in the Info.plist #37106

Merged
merged 1 commit into from Oct 30, 2017
Merged

Specify the UTI types for files in the Info.plist #37106

merged 1 commit into from Oct 30, 2017

Conversation

rsesek
Copy link
Contributor

@rsesek rsesek commented Oct 29, 2017

This sets the LSItemContentTypes key to ['public.source-code'], a
declared text UTI [1], which should permit QuickLook previews.

Fixes #25843

[1]
https://developer.apple.com/library/content/documentation/Miscellaneous/Reference/UTIRef/Articles/System-DeclaredUniformTypeIdentifiers.html#//apple_ref/doc/uid/TP40009259-SW1

@bpasero bpasero removed their assignment Oct 30, 2017
@joaomoreno joaomoreno added this to the October 2017 milestone Oct 30, 2017
@joaomoreno
Copy link
Member

Epic, thanks! 🍻

@joaomoreno joaomoreno added install-update VS Code installation and upgrade system issues macos Issues with VS Code on MAC/OS X workbench-os-integration Native OS integration issues and removed install-update VS Code installation and upgrade system issues labels Oct 30, 2017
@joaomoreno joaomoreno merged commit 5a0d5fe into microsoft:master Oct 30, 2017
@rsesek rsesek deleted the LSItemContentTypes branch October 30, 2017 19:00
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
macos Issues with VS Code on MAC/OS X workbench-os-integration Native OS integration issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement - explore adding quicklook for vscode for osx
3 participants