New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the UTI types for files in the Info.plist #37106

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
3 participants
@rsesek
Contributor

rsesek commented Oct 29, 2017

This sets the LSItemContentTypes key to ['public.source-code'], a
declared text UTI [1], which should permit QuickLook previews.

Fixes Microsoft/vscode#25843

[1]
https://developer.apple.com/library/content/documentation/Miscellaneous/Reference/UTIRef/Articles/System-DeclaredUniformTypeIdentifiers.html#//apple_ref/doc/uid/TP40009259-SW1

@bpasero bpasero removed their assignment Oct 30, 2017

@joaomoreno joaomoreno added this to the October 2017 milestone Oct 30, 2017

@joaomoreno

This comment has been minimized.

Show comment
Hide comment
@joaomoreno

joaomoreno Oct 30, 2017

Member

Epic, thanks! 🍻

Member

joaomoreno commented Oct 30, 2017

Epic, thanks! 🍻

@joaomoreno joaomoreno merged commit 5a0d5fe into Microsoft:master Oct 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rsesek rsesek deleted the rsesek:LSItemContentTypes branch Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment