Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #35361: fix native tabs on macOS 10.13 #52775

Merged
merged 2 commits into from Jun 25, 2018
Merged

Conversation

@zhuowei
Copy link
Contributor

@zhuowei zhuowei commented Jun 24, 2018

macOS 10.13 mistakenly enables a compatibility option on VS Code and VS Code Insiders because their bundle IDs begin with "com.microsoft.". This breaks native tabs.

Explicitly disable the compatibility patch using NSUserDefaults.

Note that Code-OSS is not affected by the bug, since its bundle ID is "com.visualstudio.code.oss". To test this behaviour, change darwinBundleIdentifier in product.json.

See #35361 for more information.

@bpasero

macOS 10.13 mistakenly enables a compatibility option on VS Code
and VS Code Insiders because their bundle IDs begin with
"com.microsoft.". This breaks native tabs.

Explicitly disable the compatibility patch using NSUserDefaults.

Note that Code-OSS is not affected by the bug, since its bundle ID
is "com.visualstudio.code.oss". To test this behaviour, change
darwinBundleIdentifier in product.json.
@nzec
nzec approved these changes Jun 25, 2018
@bpasero bpasero added this to the June 2018 milestone Jun 25, 2018
@bpasero bpasero self-assigned this Jun 25, 2018
@bpasero bpasero merged commit 8e03e03 into microsoft:master Jun 25, 2018
1 of 2 checks passed
1 of 2 checks passed
VSTS: VS Code in progress
Details
license/cla All CLA requirements met.
@bpasero
Copy link
Member

@bpasero bpasero commented Jun 25, 2018

@zhuowei thanks ❤️ , I added a small adjustment to only set this when the window.nativeTabs is enabled to reduce the risk of breaking people that are not using native tabs.

bpasero added a commit that referenced this pull request Jun 25, 2018
This reverts commit 8e03e03.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants