Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed emmet validation when open angle bracket is followed by space #55762
Fix for issue #55411.
Much like the check for PHP's
This will fix issues where, for example, emmet won't trigger in JSX when the if statement contains a
This will not work if the there is no space after the angle bracket, as in
referenced this pull request
Aug 3, 2018
I am not used to your standards yet and the coding guidelines didn't mention anyting in regard to that, but I decided to add another condition instead of adding an OR to the existing PHP check just to have more explicit checks.
Of course this could easily be refactored as
That's awesome ! пт, 3 авг. 2018 г., 23:33 Ramya Rao <firstname.lastname@example.org>:…
***@***.**** approved this pull request. Thanks @mathdeziel <https://github.com/mathdeziel>. We are currently at the end of the testing phase for the current iteration. So, I'll merge this sometime next week for the next iteration. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#55762 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVPRpVJEYgLuJ1A10mhlXy-5XPzjgYEIks5uNLOggaJpZM4VuFLQ> .