New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show README instead of welcome page, if it exists #60061

Merged
merged 3 commits into from Nov 6, 2018

Conversation

Projects
None yet
5 participants
@iamnapo
Copy link
Contributor

iamnapo commented Oct 6, 2018

Fixes #31450

I opened this early as a WIP, because this codebase is huge(!) and I could use any incoming feedback. I'll rename it, when it's ready.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Oct 6, 2018

CLA assistant check
All CLA requirements met.

@chrmarti
Copy link
Contributor

chrmarti left a comment

Thanks for working on this. Please see my comments.

@jaywick

This comment has been minimized.

Copy link

jaywick commented Oct 11, 2018

@iamnapo I would love to help out in any way, let me know how we can coordinate :)

@iamnapo

This comment has been minimized.

Copy link
Contributor

iamnapo commented Oct 13, 2018

@jaywick Thanks! I think I figured everything out, but if you have any suggestions on code refactoring, LMK

@iamnapo iamnapo changed the title [WIP] Show README instead of welcome page, if it exists Show README instead of welcome page, if it exists Oct 16, 2018

@chrmarti chrmarti added this to the October 2018 milestone Oct 25, 2018

@chrmarti chrmarti modified the milestones: October 2018, November 2018 Nov 2, 2018

@chrmarti chrmarti merged commit e6a3b8f into Microsoft:master Nov 6, 2018

1 of 2 checks passed

VS Code #20181013.3 failed
Details
license/cla All CLA requirements met.
Details
@chrmarti

This comment has been minimized.

Copy link
Contributor

chrmarti commented Nov 6, 2018

Just missing handling of err from readdir. Will add that. Thanks @iamnapo !

@arendjr

This comment has been minimized.

Copy link

arendjr commented Nov 7, 2018

Thanks for implementing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment