New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #60724 - Terminal:SelectBox: Terminal select box should have main ARIA label #61466

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
4 participants
@skprabhanjan
Contributor

skprabhanjan commented Oct 22, 2018

@cleidigh
cc : @Tyriar
This fixes #60724 , just changed the label value.
PS: The entire interface is not passed as you had suggested.

@cleidigh

This comment has been minimized.

Collaborator

cleidigh commented Oct 23, 2018

@skprabhanjan
Looks good.
Tweak the PR title to be clear what this is beyond just the "Fixes #XYZ" - makes tracking easier.
then I will merge...

@skprabhanjan skprabhanjan changed the title from Fixes #60724 to Fixes #60724 - Terminal:SelectBox: Terminal select box should have main ARIA label Oct 23, 2018

@skprabhanjan

This comment has been minimized.

Contributor

skprabhanjan commented Oct 23, 2018

@skprabhanjan
Looks good.
Tweak the PR title to be clear what this is beyond just the "Fixes #XYZ" - makes tracking easier.
then I will merge...

@cleidigh , sorry for that!
Hope its good now, Thanks :)

@cleidigh cleidigh merged commit 9b19f82 into Microsoft:master Oct 23, 2018

@Tyriar Tyriar added this to the October 2018 milestone Oct 23, 2018

@AndreiShybin

This comment has been minimized.

AndreiShybin commented Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment