Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tasks.json should use deprecation message for env. config. and command. #62787

Merged
merged 3 commits into from Nov 13, 2018
Merged

tasks.json should use deprecation message for env. config. and command. #62787

merged 3 commits into from Nov 13, 2018

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Nov 8, 2018

Fixes #21340

@alexr00 alexr00 added this to the November 2018 milestone Nov 8, 2018
@isidorn
Copy link
Contributor

isidorn commented Nov 8, 2018

Looks good to me. Nice work.
I am not a big fan of adding a namespace around that utility function, but that is just personal preference.

@dbaeumer
Copy link
Member

LGTM. Same comment as @isidorn. Since we already have modules adding another namespace doesn't bring too much.

@alexr00 alexr00 merged commit fc3083d into master Nov 13, 2018
@alexr00 alexr00 deleted the alexr00/deprecatedMessage branch November 13, 2018 09:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isidorn isidorn isidorn approved these changes

@dbaeumer dbaeumer dbaeumer approved these changes

Assignees

@dbaeumer dbaeumer

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
November 2018
Development

Successfully merging this pull request may close these issues.

${command.xxx} deprecated syntax is not shown in tasks.json
3 participants
@alexr00 @isidorn @dbaeumer