Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strict null checking for abstractKeybindingService test #65483

Closed
wants to merge 1 commit into from
Closed

Enable strict null checking for abstractKeybindingService test #65483

wants to merge 1 commit into from

Conversation

oniondomes
Copy link
Contributor

@oniondomes oniondomes commented Dec 20, 2018 •
edited

#65233

  • "./vs/platform/keybinding/test/common/abstractKeybindingService.test.ts"

@msftclas
Copy link

msftclas commented Dec 20, 2018 •
edited

CLA assistant check
All CLA requirements met.

@alexdima alexdima self-assigned this Dec 20, 2018
@alexdima
Copy link
Member

alexdima commented Jan 9, 2019

Sorry about that, looks like another PR got merged by someone else which adds this to the strict null check list.

@alexdima alexdima closed this Jan 9, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oniondomes @msftclas @alexdima