add git blame api #66416
Merged
add git blame api #66416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
requested changes
Jan 14, 2019
|
|
||
| return result.stdout.trim(); | ||
| } catch (err) { | ||
| throw err; |
There was a problem hiding this comment.
Nice catch, for now we only need to specificily handle one error type no such path.
| @@ -999,6 +1000,10 @@ export class Repository implements Disposable { | |||
| await this.run(Operation.Push, () => this.repository.push(remote, undefined, false, true, forcePushMode)); | |||
| } | |||
|
|
|||
| async blame(path: string): Promise<string> { | |||
| return await this.run(Operation.Blame, () => this.repository.blame(path)); | |||
There was a problem hiding this comment.
Should we parse the blame result into something more structured?
There was a problem hiding this comment.
Similar to git log, the output of git blame is more or less free form once we add more options to it. I thought about returing string[] but for --porcelain, one info entry for a line can be multiline so I'd like to suggest to leave the parsing work to callers. Does this make sense?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add git blame api to git extension, right now I just use string for the result and users take care of the parsing.