User/gabrield/extension callback as task #66819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabeDeBacker
commented
Jan 20, 2019
|
@GabeDeBacker I don't have time atm to read through everything, but why are there are so many changes needed for this in the terminal? |
alexr00
reviewed
Jan 23, 2019
alexr00
reviewed
Jan 23, 2019
alexr00
reviewed
Jan 24, 2019
alexr00
reviewed
Jan 24, 2019
alexr00
reviewed
Jan 24, 2019
src/vs/workbench/parts/tasks/electron-browser/terminalTaskSystem.ts
Outdated
Show resolved
Hide resolved
alexr00
reviewed
Jan 24, 2019
src/vs/workbench/parts/tasks/electron-browser/terminalTaskSystem.ts
Outdated
Show resolved
Hide resolved
alexr00
reviewed
Jan 24, 2019
alexr00
reviewed
Jan 24, 2019
src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts
Outdated
Show resolved
Hide resolved
alexr00
reviewed
Jan 24, 2019
…ensionCallbackAsTask
…ensionCallbackAsTask
|
The main piece of feedback is I still think the API should only allow |
Tyriar
requested changes
Mar 6, 2019
…ensionCallbackAsTask
alexr00
approved these changes
Mar 7, 2019
Tyriar
approved these changes
Mar 7, 2019
|
Will merge after CI passes |
|
CI failed with unrelated strict null check problems, I'll assume it's all good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #66818.
Currently tasks can only execute external processes. For certain build environments that are sufficiently complex, launching an external process to perform the build is not sufficient to provide a robust user experience with VSCode.
This change allows an extension to provide a callback function as a task through ITaskProvider::ProvideTasks. When the task is executed, the extension is provided a terminal renderer for which it can provide output and accept input.
All scenarios such as task launch, terminate task, restart task and terminal re-use have been tested.
All unit-tests also pass.