Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make an error message easier to understand #69701

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Make an error message easier to understand #69701

merged 2 commits into from
Mar 5, 2019

Conversation

tamuratak
Copy link
Contributor

The error message File not formatted is confusing. It does not tell us what we should do.

joaomoreno
joaomoreno requested changes Mar 4, 2019
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd take this if the message would say Run the 'Format Document' command to fix it instead.

@joaomoreno joaomoreno added this to the Backlog milestone Mar 4, 2019
@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Mar 4, 2019
@joaomoreno joaomoreno merged commit f03dbf3 into microsoft:master Mar 5, 2019
@joaomoreno joaomoreno modified the milestones: Backlog, March 2019 Mar 5, 2019
@joaomoreno
Copy link
Member

Thanks!

@tamuratak tamuratak deleted the make_error_message_easy_to_understand branch March 6, 2019 05:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno requested changes

Assignees

@joaomoreno joaomoreno

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
March 2019
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tamuratak @joaomoreno