Fixed #59368 #70167
Merged
Fixed #59368 #70167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (value.length === 0) { | ||
| return null; | ||
| } | ||
| if (!this._findInput.getRegex()) { |
There was a problem hiding this comment.
What do you think about to put both of those conditions in one if with an OR statement?
| } | ||
| try { | ||
| /* tslint:disable:no-unused-expression */ | ||
| new RegExp(value); |
There was a problem hiding this comment.
tip: is more simple use tslint:disable-next-line:no-unused-expression instead disable and enable next 🙂
|
Thanks for the suggestions, I also applied these changes to |
|
Hey @joaomoreno , @rebornix owns the find widget since around 2 years. |
rebornix
approved these changes
Mar 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #59378.
It adds regex validation to the terminal.