Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #59368 #70167

Merged
merged 3 commits into from Mar 29, 2019

Conversation

Projects
None yet
4 participants
@irrationalRock
Copy link
Contributor

commented Mar 10, 2019

This PR fixes: #59378.

It adds regex validation to the terminal.

if (value.length === 0) {
return null;
}
if (!this._findInput.getRegex()) {

This comment has been minimized.

Copy link
@rhogeranacleto

rhogeranacleto Mar 15, 2019

What do you think about to put both of those conditions in one if with an OR statement?

}
try {
/* tslint:disable:no-unused-expression */
new RegExp(value);

This comment has been minimized.

Copy link
@rhogeranacleto

rhogeranacleto Mar 15, 2019

tip: is more simple use tslint:disable-next-line:no-unused-expression instead disable and enable next 🙂

@irrationalRock

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

Thanks for the suggestions,

I also applied these changes to FindWidget.

@alexandrudima

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Hey @joaomoreno , @rebornix owns the find widget since around 2 years.

@rebornix rebornix added this to the On Deck milestone Mar 28, 2019

@rebornix
Copy link
Member

left a comment

@irrationalRock thanks for your contribution!

@rebornix rebornix merged commit b71932d into microsoft:master Mar 29, 2019

5 checks passed

VS Code Build #20190319.43 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.