Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .nvmrc #70701

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Update .nvmrc #70701

merged 1 commit into from
Mar 19, 2019

Conversation

penx
Copy link
Contributor

@penx penx commented Mar 18, 2019

How to contribute lists recommendation of node 10:

Node.JS, 64-bit, recommended >=10.15.1, < 11.0.0
https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites

Updating .nvmrc to match

How to contribute lists recommendation of node 10:

> Node.JS, 64-bit, recommended >=10.15.1, < 11.0.0
https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites

Updating .nvmrc to match
@penx
Copy link
Contributor Author

penx commented Mar 18, 2019

I could be wrong on this... maybe the docs need updating instead? Or are different versions of node used for different tasks?

@penx
Copy link
Contributor Author

penx commented Mar 18, 2019

(I'm trying to use a Node 10 feature in an update to an open PR but keep getting errors saying it's not supported)

@joaomoreno
Copy link
Member

cc @alexandrudima

@joaomoreno joaomoreno self-requested a review March 19, 2019 07:44
@joaomoreno joaomoreno added this to the March 2019 milestone Mar 19, 2019
@joaomoreno joaomoreno merged commit 65ea299 into microsoft:master Mar 19, 2019
@penx penx deleted the patch-1 branch March 19, 2019 14:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants