Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis builds post coverage info to coveralls.io and add README badge. #9791

Merged
merged 1 commit into from Aug 12, 2016
Merged

Conversation

nojvek
Copy link
Contributor

@nojvek nojvek commented Jul 26, 2016

Seems vscode already has istanbul instrumentation enabled in tests. It would be nice to see the coverage info as a badge in the REPO readme.

You'll need to add the following environment vars in travis.

COVERALLS_REPO_TOKEN = XXXX (Generate from https://coveralls.io/repos/118314/regenerate_token)
COVERALLS_GIT_COMMIT = HEAD

@msftclas
Copy link

Hi @nojvek, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Manoj Patel). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@coveralls
Copy link

coveralls commented Jul 26, 2016

Coverage Status

Changes Unknown when pulling db9a0c5 on nojvek:master into * on Microsoft:master*.

@kieferrm kieferrm added the vscode-build VS Code build process issues label Jul 26, 2016
@joaomoreno joaomoreno added this to the July 2016 milestone Jul 27, 2016
@joaomoreno
Copy link
Member

Wow that's pretty cool.

@nojvek
Copy link
Contributor Author

nojvek commented Jul 28, 2016

@joaomoreno who would I need to cc to get a review + signoff on this ?

@joaomoreno
Copy link
Member

That would be me. Let's do it in August, though.

@joaomoreno joaomoreno modified the milestones: August 2016, July 2016 Jul 28, 2016
@nojvek
Copy link
Contributor Author

nojvek commented Jul 28, 2016

Sounds good. Will ping you in August.

I'm guessing, the delay because you're all flat out on a release?

On Thursday, July 28, 2016, João Moreno notifications@github.com wrote:

That would be me. Let's do it in August, though.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9791 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA-JVKw92dYcAkebcCbvSN2r3M4UhN1kks5qaFvBgaJpZM4JVR6c
.

@joaomoreno joaomoreno merged commit db9a0c5 into microsoft:master Aug 12, 2016
@joaomoreno
Copy link
Member

Thanks, pretty cool!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
vscode-build VS Code build process issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants