relative path for test dlls as arguments #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codito
reviewed
Jan 13, 2017
| @@ -253,6 +253,12 @@ public void AddSource(string source) | |||
| } | |||
|
|
|||
| source = source.Trim(); | |||
|
|
|||
| if(!FileHelper.IsRootedPath(source)) | |||
codito
reviewed
Jan 13, 2017
| @@ -52,5 +52,17 @@ public FileAttributes GetFileAttributes(string path) | |||
| { | |||
| return new FileInfo(path).Attributes; | |||
| } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public bool IsRootedPath(string path) | |||
There was a problem hiding this comment.
Usually we consider APIs that have filesystem interactions to be part of IFileHelper, this would allow us to inject a testable implementation easily.
Path.IsRootedPath doesn't access the file system. It is string comparison I believe.
There was a problem hiding this comment.
I was considering it more of a wrapper over C# file API, so it made sense to make it a part of FileHelper
codito
reviewed
Jan 13, 2017
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public string CombinePath(string source) |
There was a problem hiding this comment.
Can this API be made more intuitive? Or should we just provide an API to get current directory. Let the caller do Path.Combine.
Path.Combine again doesn't access the file system. It may not be provided via IFileHelper.
codito
reviewed
Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.