Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeDescriptor Fix - (For Master) #530

Merged
merged 2 commits into from Feb 22, 2017
Merged

TypeDescriptor Fix - (For Master) #530

merged 2 commits into from Feb 22, 2017

Conversation

singhsarab
Copy link
Contributor

  • Instead of register the custom converters with TypeDescriptor, use them as static fields.
  • Removing the custom guid converter
  • Fixed the InProcDataCollector Test

@singhsarab
TypeDescriptor Fix
d35fe40 
- Instead of register the custom converters with TypeDescriptor, use them as static fields.
- Removing the custom guid converter
- Fixed the InProcDataCollector Test
@msftclas
Copy link

Hi @singhsarab, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@singhsarab singhsarab merged commit b78eafa into microsoft:master Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codito codito codito approved these changes

@smadala smadala Awaiting requested review from smadala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@singhsarab @msftclas @codito