(issue #946) visual studio command-line build vnext step (devenv.com) #1080
Conversation
|
Hi @jmacnett, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
did that. enjoy. |
|
@jmacnett, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
@jmacnett You did a good job, especially around the effort of going trough the invocation output and trying to match and handle errors. I do see however a place for some minor improvements. I will try to draft and test them and then I'll make a pull request to your branch. Thanks for sharing |
|
I think we are going to support this but in a slightly different way. We want an input on the existing Visual Studio Build task that says use devenv (defaults to false). If true, it takes the variant path running code similar to above. We don't want another task. The current VS build task is essentially still running msbuild but the purpose of it is to location the proper version of msbuild via the specified VS version. Do you want to take a crack at that PR? We can help CR, test, etc... Also, take a look at how we're writing L0 tasks via mocking. The goal is to exercise every arc/function of the script without actually doing the work and runs sub second. |
|
I'm not opposed to implementing it in that fashion, if that's the desired approach. I can certainly take a crack at modifying the existing visual studio build task as described. With that said, how set is your team on this approach? My concern with having the two paths within that same task is that the command-line arguments for devenv vs msbuild are pretty divergent, beyond a point. In fact, it almost seems that the use-visual-studio-to-select-a-version-of-msbuild logic could be in the MSBuild task template, in parallel w/ the msbuild version selection UI, and the devenv/VS build option could be it's own task option. Again, I'm just asking...seems like a more intuitive approach to me. I am willing to spend some time on this in either case, as I'd like to see it become part of the standard vnext offerings. Thanks! |
|
We're pretty set. We don't want a proliferation of tasks. Switching on which cmd line to call us a minor implementation detail. When you have both tasks that are at a glance the same ( vs / devenv ) it's confusing which to pick. If you have one then inside the context of giving inputs to the task we can offer guidance. Create a separate PR and I can pair you up with a dev on this side |
Did this die on the vine? |
|
@jmacnett ?? |
|
Where does this task stand...has it been address? completed? |
|
I started working on this code when I first posted my question. I did make some progress but it isn't ready for putting into a pull request yet. I haven't touched it for a number of weeks now (I took another track in my project shortly after this thread went silent). I was kinda waiting to see if someone in the team might be assigned to this and give me the guidance that was offered to jmacknett. Reading it again now, I see that you had asked him to created a PR first. If you want to see what I've done so far, I can do a PR. Mike From: rrober07mailto:notifications@github.com Where does this task stand...has it been address? completed? — |
|
Has this been completed? where can I get the copy to update our TFS2015 update 3... thanks |
|
I haven’t created a pull request for this yet, I hadn’t heard that you wanted one from me. Sorry about that. Last I checked, I needed to merge in a bunch of changes before I was able to get my change in. What is your timeline for this release? If I did this on the weekend, would it be too late? Mike Diehl sip:miked@imaginet.com [cid:image007.png@01CEF68D.19A9C0A0]http://www.imaginet.com/ From: rrober07 [mailto:notifications@github.com] Has this been completed? where can I get the copy to update our TFS2015 update 3... thanks — |
|
no problem...This weekend would be fine...let me know Thanks On Mon, Sep 19, 2016 at 3:11 PM, xhead notifications@github.com wrote:
|
|
Where you able to get those changes finished last weekend? Let me Thanks On Mon, Sep 19, 2016 at 3:20 PM, Richard Roberts roberts.vb@gmail.com
|
|
The right fix is to add a bool input to the VSBuild task to use devenv.exe. If you want a PR then that's the right approach. |
|
which branch should I request? On Tue, Sep 27, 2016 at 7:17 AM, Bryan MacFarlane notifications@github.com
|
|
HM, the way I built mine was to add a third choice, devenv.com, to the two msbuild choices. Sent from my Windows Phone From: Bryan MacFarlanemailto:notifications@github.com The right fix is to add a bool input to the VSBuild task to use devenv.exe. If you want a PR then that's the right approach. — |
|
Right. And that's problematic because when someone uses the mainline default option of msbuild (we default to the lighter weight cmdline approach) and realize for some reason they want to switch to using devenv (there were unfortunately some scenarios that only work from VS), they shouldn't have to remove a step, add a new step, and re-input all the data. They should just flip a toggle. |
|
What branch is your change in...so I can pull that? On Tue, Sep 27, 2016 at 9:17 AM, xhead notifications@github.com wrote:
|
|
I still haven't checked it in Sent from my Windows Phone From: rrober07mailto:notifications@github.com What branch is your change in...so I can pull that? On Tue, Sep 27, 2016 at 9:17 AM, xhead notifications@github.com wrote:
— |
|
What branch should I request to pull for this switch? On Tue, Sep 27, 2016 at 10:03 AM, Bryan MacFarlane <notifications@github.com
|
|
I don't have it in yet Sent from my Windows Phone From: rrober07mailto:notifications@github.com What branch should I request to pull for this switch? On Tue, Sep 27, 2016 at 10:03 AM, Bryan MacFarlane <notifications@github.com
— |
|
I am assuming this has been fixed or moved to the TFS15 version coming since it has been closed |
|
bryan,
what ever happened to VSBuild using Devenv? has it been implemented? we
can not build SSRS,SSIS,SSAS with MSBuild? This is a roadblock for our
team...how have others solved for builds in TFS2015?
Richard
…On Tue, Sep 27, 2016 at 7:17 AM, Bryan MacFarlane ***@***.***> wrote:
Closed #1080 <#1080>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1080 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHanqzzyOMStqHljaIqn9TA3z2UNBV0ks5quQlhgaJpZM4HF4lQ>
.
|
|
what state is this ? when might we see this ? |
|
I've abandoned it. It's easier to write a command task than to update this code.
…Sent from my Windows Phone
________________________________
From: psandhu79<mailto:notifications@github.com>
Sent: 9/21/2017 3:12 PM
To: Microsoft/vsts-tasks<mailto:vsts-tasks@noreply.github.com>
Cc: Mike Diehl<mailto:Miked@imaginet.com>; Comment<mailto:comment@noreply.github.com>
Subject: Re: [Microsoft/vsts-tasks] (issue #946) visual studio command-line build vnext step (devenv.com) (#1080)
what state is this ? when might we see this ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1080 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ASUnpyP5n3ANnC2SAo9YhMtzoL0Jgqcmks5sksMvgaJpZM4HF4lQ>.
|
|
But is there an easy way of detecting where the visual studio is installed on the machine if using on-prem agents or hosted ones ? |
|
I've used an on prem agent
…Sent from my Windows Phone
________________________________
From: psandhu79<mailto:notifications@github.com>
Sent: 9/22/2017 3:19 AM
To: Microsoft/vsts-tasks<mailto:vsts-tasks@noreply.github.com>
Cc: Mike Diehl<mailto:Miked@imaginet.com>; Comment<mailto:comment@noreply.github.com>
Subject: Re: [Microsoft/vsts-tasks] (issue #946) visual studio command-line build vnext step (devenv.com) (#1080)
But is there an easy way of detecting where the visual studio is installed on the machine if using on-prem agents or hosted ones ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1080 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ASUnpxmvsYVues0VuZe2VowMU7afh5-Sks5sk214gaJpZM4HF4lQ>.
|
|
There are some registry keys with install locations for vs. The source code for this task uses then to find msbuild.
…Sent from my Windows Phone
________________________________
From: psandhu79<mailto:notifications@github.com>
Sent: 9/22/2017 3:19 AM
To: Microsoft/vsts-tasks<mailto:vsts-tasks@noreply.github.com>
Cc: Mike Diehl<mailto:Miked@imaginet.com>; Comment<mailto:comment@noreply.github.com>
Subject: Re: [Microsoft/vsts-tasks] (issue #946) visual studio command-line build vnext step (devenv.com) (#1080)
But is there an easy way of detecting where the visual studio is installed on the machine if using on-prem agents or hosted ones ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1080 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ASUnpxmvsYVues0VuZe2VowMU7afh5-Sks5sk214gaJpZM4HF4lQ>.
|
issue #946
Functional, configurable vnext step allowing the user to invoke devenv.com and build via visual studio, instead of msbuild. This adds back in support for project types that msbuild doesn't handle (SSRS projects, for example).