Fixed a version change of vsts-task-lib breaking calls to tl.cp() #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Sep 15, 2016
| @@ -44,7 +44,7 @@ export class CodeAnalysisResultPublisher { | |||
| let reportName = path.basename(resultFile, extension); | |||
|
|
|||
| let artifactName = `${prefix}_${reportName}_${analysisResult.toolName}${extension}`; | |||
| tl.cp('-f', resultFile, path.join(destinationDir, artifactName)); | |||
| tl.cp(resultFile, path.join(destinationDir, artifactName), '-f'); | |||
There was a problem hiding this comment.
Do we need to use tl.cp instead of the underlying shell.cp ? Actually copying files means that we can test this (i.e. test that the destination folder contains the test files).
There was a problem hiding this comment.
In test, tl.mkdirP() doesn't do anything either and the two go hand-in-hand.
|
curious - did the break happen when adopting a new version of the task lib? we made changes in minor versions on the way to 1.0 lib. |
|
@bryanmacfarlane This emerged in production when Maven and Gradle package.json files were changed to bump us from 0.7.4 -> 0.9.7: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.