This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Add delete (when files deleted in Explorer) #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update telemetry (we don't want to send any on file operations) Miscellaneous clean up
jpricket
reviewed
Feb 16, 2017
src/tfvc/commands/delete.ts
Outdated
| let lines: string[] = CommandHelper.SplitIntoLines(executionResult.stdout, false, true /*filterEmptyLines*/); | ||
|
|
||
| if (executionResult.exitCode === 100) { | ||
| CommandHelper.ProcessErrors(this.GetArguments().GetCommand(), executionResult, true); |
There was a problem hiding this comment.
Seems like this should come first. No need to split the lines if this throws. The exit code check also seems unnecessary if you only expect 100 or 0.
jpricket
reviewed
Feb 16, 2017
src/tfvc/commands/delete.ts
Outdated
| return {}; | ||
| } | ||
|
|
||
| //Delete returns either 0 (success) or 100 (failure). IF we fail, simply throw. |
There was a problem hiding this comment.
some example output would be helpful for understanding the parsing.
jpricket
approved these changes
Feb 16, 2017
| let deleteCandidatePaths: string[] = []; | ||
| for (let index: number = 0; index < changes.length; index++) { | ||
| let change: IPendingChange = changes[index]; | ||
| if (change.isCandidate && GetStatuses(change.changeType).find((e) => e === Status.DELETE)) { |
There was a problem hiding this comment.
You can use change.HasStatus(Status.DELETE) here. I think it does the same thing.
There was a problem hiding this comment.
I need a Resource first (and don't have one at this point). Instead of creating one, I'll do this instead.
Adding sample output Moving error checking to start of function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update telemetry (we don't want to send any on file operations)
Miscellaneous clean up