Update xunit version to 2.4 and target NS2.0 #269
Conversation
…stable versions (microsoft#257)" (microsoft#262)" This reverts commit 7f538aa.
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <AssemblyTitle>xunit.performance.core</AssemblyTitle> | |||
| <TargetFramework>netstandard1.3</TargetFramework> | |||
| <TargetFramework>netstandard2.0</TargetFramework> | |||
There was a problem hiding this comment.
nit: I think this could stay as netstandard1.3
There was a problem hiding this comment.
netstandard2.0 pull less dependencies in which results in a cleaner package graph.
|
@ViktorHofer there are some build failures. |
| @@ -72,7 +72,7 @@ setlocal | |||
| cd /d %~dp0tests\simpleharness | |||
| call :dotnet_build || exit /b 1 | |||
|
|
|||
| for %%v in (netcoreapp1.0 netcoreapp1.1 netcoreapp2.0 net461) do ( | |||
| for %%v in (netcoreapp2.0 net461) do ( | |||
There was a problem hiding this comment.
Should we add netcoreapp2.1 testing too, and download latest tooling too: 2.1.300?
There was a problem hiding this comment.
I don't have a strong opinion here but I think netcoreapp2.0 is enough for the test matrix.
|
Builders might be though to resolve as it conflicts with the CommandLineParser package which has beta dependencies... |
|
Can it be fixed by specifying the package version on the test projects (use System.Resources.ResourceManager 4.3.0)? |
|
I'm not sure, I don't think so as the dependency is pulled in by CommandLineParser. But I will quickly fork it and retarget it to NS2.0 and send a PR to them. Isn't much work. |
|
Port done here: commandlineparser/commandline#307 |
|
Till my PR gets merged in the commandlineparser repo I uploaded the temporarily locally built package to nuget and referenced it here to unblock further work. |
|
Is this package in myget? |
|
nuget :) |
|
@dotnet-bot test this please |
|
To be honest, I've no idea why the other two tests are failing / why xunit.runner.utility.netstandard20.dll can't be loaded... |
|
Tests failed because of xunit/xunit#1594 (comment). It seems this was never fixed. Adding netcoreapp2.0 and net461 tfms resolves the right assembly. |
|
Yes, this is how xunit is packaged :( |
cc @jorive