Skip to content
This repository has been archived by the owner on Dec 9, 2020. It is now read-only.

BotAuth is obsolete? #61

Closed
dnws opened this issue May 25, 2018 · 6 comments
Closed

BotAuth is obsolete? #61

dnws opened this issue May 25, 2018 · 6 comments

Comments

@dnws
Copy link

dnws commented May 25, 2018

BotBuilder since release 3.15.1.0 supports generic OAuth flows and AADv1/v2 authentication methods out of the box. There are examples for each auth flow in official documentation. Integrated flows are also capable of making all the verifications in the background. This project even being presented on Build 2018 seem to be abandoned.

@mattdot should it be discontinued and marked as such?

@josephktcheung
Copy link

@dnws I want to use built-in OAuth in bot service too but the lack of documentation makes it impossible for me to implement the flow with Auth0. Please read the comments in the documentation page where people are complaining about the lack of documentation, examples and problems like refreshing tokens not working etc.

BotAuth can serve as an alternative to people who are not yet satisfied with the bot service OAuth implementation, until most questions in the official documentation comments section are answered,
documentation is more polished and more examples are provided.

@rgarita
Copy link

rgarita commented Jun 4, 2018

I had issues with BotBuilder OAuth cards on teams, so I'm back on this one.......

@EricDahlvang
Copy link
Collaborator

@rgarita What were the issues you ran into with OAuth cards on teams?

@belcsy
Copy link

belcsy commented Jun 12, 2018

I have some issues with the BotBuilder OAuth card as well.

The error i constantly get is that 'Parameter "url" must be a string, not undefined' in the Bot Emulator. I have tried to change the 'value: undefined' to a fixed value in OAuthCard.js, but it is not working as well. I couldn't find any documentation on where exactly i should provide a url...

I bounced back to BotAuth, which is now working better for me

@rgarita
Copy link

rgarita commented Jun 13, 2018

@EricDahlvang

Basically I cannot click on it... It does work on the webchat version but not on teams

Raul

@dnws
Copy link
Author

dnws commented Nov 2, 2018

Closing this issue, as library is now officially marked as obsolete in commit 0988df6.

@dnws dnws closed this as completed Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants