Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker installation script now tells users to install Docker Desktop for Windows when run in WSL #1705

Open
adrastogi opened this issue Jan 13, 2023 · 1 comment

Comments

@adrastogi
Copy link

Documentation Issue

Noticed this when setting up a new machine a little while back... the script at https://get.docker.com now explicitly checks if it's being invoked from WSL, and if so, instructs the user to install Docker Desktop for Windows instead:

From the script:

        if is_wsl; then
                echo
                echo "WSL DETECTED: We recommend using Docker Desktop for Windows."
                echo "Please get Docker Desktop from https://www.docker.com/products/docker-desktop"
                echo
                cat >&2 <<-'EOF'

                        You may press Ctrl+C now to abort this script.
                EOF
                ( set -x; sleep 20 )
        fi

Link to documentation page

https://learn.microsoft.com/en-us/windows/wsl/tutorials/gpu-compute

Suggested Improvements

I think step 2 of the instructions can be updated to just recommend installing Docker Desktop for Windows. (I am less confident about what additional changes are needed downstream of that, which is why I hesitated on sending a PR- for example, is it still necessary to install the NVIDIA Container Toolkit? If so, are the current instructions accurate? The NVIDIA document that is linked to doesn't seem to have the associated chapter anymore. Hopefully someone familiar with the updated recommendations can review the rest of the document for accuracy.)

@kasparpalgi
Copy link

Hey! So can't install anymore at all or just with this script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants