Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitations Not Listed in the Documentation: Connect your GitHub repositories to Microsoft Defender for Cloud #100017

Closed
arindam0310018 opened this issue Oct 16, 2022 · 10 comments

Comments

@arindam0310018
Copy link
Contributor

Hello Team,

I did my Testing on the Recent released topic in MS Ignite 2022 - Connect your GitHub repositories to Microsoft Defender for Cloud
I also prepared a blog for the same - https://github.com/arindam0310018/14-Oct-2022-DevOps__MS-Defender-4-Cloud-DevOps-Secuirty-In-GitHub

Below limitations are not listed in your documentation:-

LIMITATIONS REFERENCE SCREENSHOT
Connector Name Cannot be more than 20 Characters 4-MS-Defender-DevOps-Security
Defender for DevOps Only Supports Central US During Preview 5-MS-Defender-DevOps-Security
In Order to Create Github Connector, Subscription MUST BE Registered to "Microsoft.SecurityDevOps" 6-MS-Defender-DevOps-Security
If the user waits too long after successful completion of the Step - "Authorize Defender for DevOps" + "Install Defender for DevOps Apps", it Fails to create the Connector with the Error - "The code Passed is Incorrect or Expired" 10

Request you to please include in the documentation.

Many Thanks
Regards, Arindam Mitra


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

@YashikaTyagii
Copy link
Contributor

@arindam0310018
Thanks for your feedback! We will investigate and update as appropriate.

@arindam0310018
Copy link
Contributor Author

Hi @YashikaTyagi-MSFT - Request for an update ?

Many Thanks
Regards, Arindam Mitra

@YashikaTyagii
Copy link
Contributor

@arindam0310018
I have assigned the issue to author who will update the document accordingly.
it is also possible to make these changes yourself, if you are interested. Doing so will improve our documentation, and it will add you as a contributor to the document.
In case you're interested, these are the steps to do so:

Navigate to the page of interest
Select the "Edit" button at the top right of the page
Select the "Pencil" icon on the right
Modify the text within the text box in markdown format - more info: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet
Name your file change and provide a description, if necessary
Select "Propose file change"
Select "Create pull request" on the 'Comparing changes' page
Select "Create pull request" on the 'Open a pull request' page
You can find a GIF that demonstrates the end-to-end process for submitting changes here: https://aka.ms/editsqldocs.

@ElazarK
Copy link
Contributor

ElazarK commented Oct 30, 2022

Hi @arindam0310018 I am currently looking in to this and hope to have an answer for you soon.

@arindam0310018
Copy link
Contributor Author

Hello @YashikaTyagi-MSFT @ElazarK
Thank you for your advise.
I have raised an PR Now - #100739

Many Thanks
Regards, Arindam Mitra

@ElazarK
Copy link
Contributor

ElazarK commented Nov 2, 2022

@arindam0310018 I spoke with the principal PM regarding this matter and the docs will be updated to reflect some of this information.

@ElazarK
Copy link
Contributor

ElazarK commented Nov 2, 2022

#please-close

@arindam0310018
Copy link
Contributor Author

Hello @ElazarK
Thank you for the reply.
It would have been good if you would have closed the issue after the changes has been committed.
Nonetheless. I will keep an eye on the change to be made.

Many Thanks
Best Regards, Arindam Mitra

@ElazarK
Copy link
Contributor

ElazarK commented Nov 3, 2022

@arindam0310018 i tried to close using the automated process and I am not sure why it did not work. Since i did not open the item i do not have access to close it other than via the automated way.

image

I appreciate both the feedback and the assistance with closing the item. I will look into why it did not close.

@arindam0310018
Copy link
Contributor Author

Hello @ElazarK
Thank you for your reply and Thank you very much for making the changes in the documentations.
I can now see the changes in the documentation - https://learn.microsoft.com/en-us/azure/defender-for-cloud/quickstart-onboard-github

  • Connector Name Cannot be more than 20 Characters
    image

  • Defender for DevOps Only Supports Central US During Preview
    image

  • In Order to Create Github Connector, Subscription MUST BE Registered to "Microsoft.SecurityDevOps"
    image

  • If the user waits too long after successful completion of the Step - "Authorize Defender for DevOps" + "Install Defender for DevOps Apps", it Fails to create the Connector with the Error - "The code Passed is Incorrect or Expired"
    image

This issue was part of PR - #100739

Many Thanks
Best Regards, Arindam Mitra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants