Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is depends_on supported by docker-compose in Web Apps for Containers? #38966

Closed
townxelliot opened this issue Sep 16, 2019 · 4 comments
Closed

Comments

@townxelliot
Copy link

townxelliot commented Sep 16, 2019

The article

https://docs.microsoft.com/bs-latn-ba/azure/app-service/containers/tutorial-multi-container-app

gives an example which shows depends_on being used in a docker-compose.yml file for creating a multi-container app.

However, there is a page linked to this one:

https://docs.microsoft.com/bs-latn-ba/azure/app-service/containers/configure-custom-container

with a section about supported docker-compose options (https://docs.microsoft.com/bs-latn-ba/azure/app-service/containers/configure-custom-container#docker-compose-options).

This list shows that the depends_on option is ignored.

If this is the case, the examples which use depends_on to link containers are presumably invalid.

Could you please confirm whether depends_on is expected to work (my experience is that it does not)? If it does not, could you please explain how to create connections between containers in a multi-container app without using depends_on?


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@BryanTrach-MSFT
Copy link
Member

@townxelliot Thanks for the feedback! We are currently investigating and will update you shortly.

@BryanTrach-MSFT
Copy link
Member

@townxelliot We have also been unable to successfully use the depends_on feature with our docker image, which conflicts with the doc. As a result, we have assigned the feedback to the author to review this doc and make any changes as necessary. Thank you for raising this up.

@msangapu-msft
Copy link
Contributor

Hi @townxelliot. Thank you for the feedback. As mentioned in the article, the Docker Compose sample was taken from https://docs.docker.com/compose/wordpress/#define-the-project . The sample includes "depends_on" and we didn't remove it because depends_on is ignored and has no effect on the configuration. I will update the article to call this out so it's not misleading. Thanks for pointing this out.

In terms of connections between containers, if you're asking how does a container know the other is online - you should include a retry mechanism to dependent services when the connection is dropped.

@msangapu-msft
Copy link
Contributor

msangapu-msft commented Oct 17, 2019

Hi @townxelliot, the article actually had an area for Supported Configuration options. I moved it above the Docker sample to help with visibility. The change will be live tomorrow morning. Thanks again for your feedback.

#please-close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants