codecop-aa0181.md

title	description	ms.author	ms.date	ms.topic	author	ms.reviewer
CodeCop Warning AA0181	Avoid getting the dataset when an enumeration is not used, which will decrease performance.	solsen	05/14/2024	reference	SusanneWindfeldPedersen	solsen

CodeCop Warning AA0181

The FindSet() or Find() methods must be used only in connection with the Next() method.

Description

Avoid getting the dataset when an enumeration is not used, which will decrease performance.

Reason for the rule

If you use FindSet() or Find() you must have a Next() method. Otherwise, you are wasting CPU and bandwidth since multiple records are loaded but you only use one.

Bad code example

codeunit 1 MyCodeunit
{
   var
      customer: Record Customer;
                
   procedure Foo()
   begin
      if customer.FindFirst() then
         repeat
         ...
         until customer.Next() = 0;
      end;
}

Good code example

codeunit 1 MyCodeunit
{
   var
      customer : Record Customer;
                
   procedure Foo()
   begin
      if customer.FindSet() then
         repeat
         ...
         until customer.Next() = 0;
      end;
}

See Also

CodeCop Analyzer
Get Started with AL
Developing Extensions