Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images does not changes when "Read in english" is selected from a translated version. #786

Open
OtacilioN opened this issue Oct 19, 2018 · 9 comments
Assignees
Labels
loc Issue with content localization Pri3

Comments

@OtacilioN
Copy link

OtacilioN commented Oct 19, 2018

Describe the bug
When you are in a translated version of a document, such as in https://docs.microsoft.com/pt-br/azure/architecture/patterns/pipes-and-filters, you have a slider called "Read in English", when you activate the slider all the text is translated, but the images still the same, with texts in the original language (Portuguese in the case)

To Reproduce

  1. Go to 'https://docs.microsoft.com/pt-br/azure/architecture/patterns/pipes-and-filters'
  2. Click on 'Ler em inglês' button
  3. Scroll down to 'https://docs.microsoft.com/pt-br/azure/architecture/patterns/pipes-and-filters#context-and-problem'
  4. Check that all the text on the page is translated, but the text on the image stills not translated

Expected behavior
The image should be reloaded and the image with English texts should be shown

Screenshots

screen shot 2018-10-19 at 17 45 57

screen shot 2018-10-19 at 17 46 06

screen shot 2018-10-19 at 17 45 41

Desktop (please complete the following information):

  • OS: macoOS
  • Browser Google Chrome and Safari
@Powerhelmsman
Copy link
Collaborator

@SonjaSaltzman Can you take a look at this issue?

@Powerhelmsman Powerhelmsman added the loc Issue with content localization label Oct 19, 2018
@SonjaSaltzman
Copy link

@OtacilioN this is a great catch, thank you for bringing it to our attention. The slider just changes the display language of the body text, but the user is still in the localized site (to fully change to the English site, you would have to use the language picker at the bottom left of the page; it will then change the chrome, text, and images to English).
Adding @bodhigautam to investigate if we can address this.

@bodhigautam
Copy link

@OtacilioN Great observation. I found out that the image has an English version so its a valid issue.
@SonjaSaltzman I will work on it.

@OtacilioN
Copy link
Author

Okay, thanks, folks!

@SonjaSaltzman
Copy link

@bodhigautam can this be closed or still requires work?

@bodhigautam
Copy link

@SonjaSaltzman This is as designed and we will have to work with Engineering team to get this enabled. I will keep it open till we have a feature rolled out for this.

@OtacilioN
Copy link
Author

OtacilioN commented Mar 6, 2019

Cool, if you folks are hiring software engineer interns, remember to refer me, I will be glad to help you with this issue 😄

@PRMerger9 PRMerger9 added the Pri3 label Apr 2, 2020
@srvbpigh
Copy link

srvbpigh commented Apr 2, 2020

Hello, @OtacilioN

Thank you for your feedback.

We are actively reviewing your comments and will get back to you soon.

Kind regards,
Microsoft DOCS International Team

@OtacilioN
Copy link
Author

Cool! 🥰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loc Issue with content localization Pri3
Projects
None yet
Development

No branches or pull requests

8 participants